default classification scheme OU setting not retrieved properly

[Galen Charlton]

When inserting a new volume, if the label class is not supplied, the asset.label_normalizer() trigger function gets the default value from the cat.default_classification_scheme OU setting. However, this lookup does not check ancestors of the volume owning library, meaning that the wrong value could be chosen if the OU setting is not set for that particular OU.

Evergreen: master

[Galen Charlton (gmc)]

Patch available in the working/Evergreen.git repository at the tip of the branch user/gmcharlt/lp825303_fix_default_class_lookup

Test plan:

[1] Set the cat.default_classification OU to Dewey (i.e., value = 2) at the root OU and make sure that the setting is not set for any child OU.
[2] Insert an asset.call_number row that doesn't specify the label class explicitly, e.g.,

insert into asset.call_number(creator, editor, record, label, owning_lib) values (1,1, 1234, 'ABC', 3);

[3] Examine the label_class value of the new acn row. Without the patch, it should be 1. After the patch is applied, it should be 2.

[Dan Scott (denials)]

Applied this patch to our production 2.0 system, it seems to work nicely. Candidate for backport to 2.0?

[Galen Charlton (gmc)]

I see no reason not to backport to 2.0.

[Dan Scott (denials)]

Well, nicely except that it was throwing an error because actor.org_unit_setting_ancestor() was returning more than one row in a context that can only accept one row, thereby preventing any new call numbers from being added.

Bandaid fix was to add a LIMIT 1 clause to the asset.label_normalizer() function:

    IF NEW.label_class IS NULL THEN
            NEW.label_class := COALESCE(
            (
                SELECT substring(value from E'\\d+')::integer
                FROM actor.org_unit_ancestor_setting('cat.default_classification_scheme', NEW.owning_lib)
                LIMIT 1
            ), 1
        );
    END IF;

but there may be deeper issues with actor.org_unit_setting_ancestor() that need to be handled.

[Galen Charlton (gmc)]

I've pushed an additional patch to user/gmcharlt/lp825303_fix_default_class_lookup that corrects the return semantics of actor.org_unit_setting_ancestor().

[Mike Rylander (mrylander)]

Pushed into master and 2.1, thanks Dan and Galen!

[Mike Rylander (mrylander)]

And, 2.0 as well.