hard to reuse common features in ec2 provider code
Bug #823385 reported by
William Reade
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| pyjuju |
Fix Released
|
Undecided
|
William Reade | ||
Bug Description
In particular, operations involving machines (getting one, getting many, terminating one, terminating all) have a couple of properties that are generally desirable, but the generic stuff is entangled with ec2-specific stuff. We need to refactor significantly before we can (for example) write common shutdown code that clears state before terminating machines.
Related branches
lp:~fwereade/pyjuju/hide-instances
- Gustavo Niemeyer: Approve
- Kapil Thangavelu (community): Approve
-
Diff: 3148 lines (+922/-1025)39 files modifiedensemble/agents/provision.py (+3/-3)
ensemble/agents/tests/test_provision.py (+12/-12)
ensemble/errors.py (+21/-21)
ensemble/ftests/test_ec2_provider.py (+24/-1)
ensemble/providers/common/findzookeepers.py (+7/-15)
ensemble/providers/common/tests/test_findzookeepers.py (+29/-53)
ensemble/providers/dummy.py (+21/-9)
ensemble/providers/ec2/__init__.py (+76/-31)
ensemble/providers/ec2/accessor.py (+0/-30)
ensemble/providers/ec2/connect.py (+0/-50)
ensemble/providers/ec2/iterate.py (+0/-49)
ensemble/providers/ec2/machine.py (+0/-30)
ensemble/providers/ec2/shutdown.py (+0/-53)
ensemble/providers/ec2/tests/common.py (+14/-5)
ensemble/providers/ec2/tests/test_accessor.py (+0/-83)
ensemble/providers/ec2/tests/test_bootstrap.py (+21/-84)
ensemble/providers/ec2/tests/test_connect.py (+47/-59)
ensemble/providers/ec2/tests/test_findzookeeper.py (+45/-82)
ensemble/providers/ec2/tests/test_getmachines.py (+178/-0)
ensemble/providers/ec2/tests/test_iterate.py (+0/-40)
ensemble/providers/ec2/tests/test_launch.py (+11/-12)
ensemble/providers/ec2/tests/test_shutdown.py (+27/-80)
ensemble/providers/ec2/tests/test_state.py (+2/-5)
ensemble/providers/ec2/tests/test_utils.py (+1/-32)
ensemble/providers/ec2/utils.py (+1/-24)
ensemble/providers/orchestra/__init__.py (+51/-46)
ensemble/providers/orchestra/cobbler.py (+42/-5)
ensemble/providers/orchestra/machine.py (+0/-6)
ensemble/providers/orchestra/tests/common.py (+11/-5)
ensemble/providers/orchestra/tests/data/launch_late_command (+2/-2)
ensemble/providers/orchestra/tests/test_bootstrap.py (+5/-6)
ensemble/providers/orchestra/tests/test_cobbler.py (+102/-25)
ensemble/providers/orchestra/tests/test_files.py (+15/-0)
ensemble/providers/orchestra/tests/test_findzookeepers.py (+8/-16)
ensemble/providers/orchestra/tests/test_getmachines.py (+100/-0)
ensemble/providers/orchestra/tests/test_launch.py (+7/-8)
ensemble/providers/orchestra/tests/test_provider.py (+0/-19)
ensemble/providers/tests/test_dummy.py (+4/-4)
ensemble/tests/test_errors.py (+35/-20)
| Changed in ensemble: | |
| milestone: | none → dublin |
| assignee: | nobody → William Reade (fwereade) |
| status: | New → In Progress |
| Changed in ensemble: | |
| milestone: | dublin → eureka |
| Changed in ensemble: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
