Patch Submission for Rhythmbox Plugin

[Graham White]

Hi Eric,

Excuse me submitting code using the bug tracker, I'm not so familiar with the Bazaar code management system so figured this might be easier for both of us. Rather than submit patch files I've just zipped up all my changes in the rhythmbox_autoqueue subdirectory.

Attached is a large update for the Rhythmbox plugin, changes from the original are:
- added config GUI
- added on/off button to RB interface when plugin is active
- added icon

Config options are stored to gconf and I've integrated them into autoqueue although some more testing is probably required in case I screwed something up.

The config GUI will automatically disable mirage and enable last.fm if mirage isn't available. However, this requires one small patch to autoqueue to move the player_set_variables_from_config() call after use_mirage has been set, otherwise plugins aren't able to determine if mirage is available at the time of their initialisation. Patch for this pasted below:

--- autoqueue/__init__.py 2011-08-05 12:48:21 +0000
+++ autoqueue/__init__.py 2011-08-09 06:41:41 +0000
@@ -136,7 +136,6 @@
         self.use_mirage = True
         self.use_lastfm = True
         self.use_groupings = True
- self.player_set_variables_from_config()
         self.get_blocked_artists_pickle()
         self.last_songs = []
         self.last_song = None
@@ -148,6 +147,7 @@
         self.similarity = dbus.Interface(
             sim, dbus_interface='org.autoqueue.SimilarityInterface')
         self.has_mirage = self.similarity.has_mirage()
+ self.player_set_variables_from_config()

     def log(self, msg):
         """Print debug messages."""

[Eric Casteleijn (thisfred)]

Awesome graham, thanks so much!

Submitting patches through the bug tracker is fine by me! I will test and add this as soon I get some time!

[Eric Casteleijn (thisfred)]

Hi Graham,

I commited your changes and made some small pep8 style fixes. I may have done something wrong, because I can't seem to get the configuration dialog to open (configure button is still greyed out.) Let me know if you have an idea of what I missed/messed up.