Have a "register" function instead of putting connection logic into constructor

Bug #821843 reported by Avi Romanoff
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Pantheon Library
Fix Released
Wishlist
Avi Romanoff

Bug Description

Currently, all of the setup logic happens in the constructor. This is fine, but seems slightly awkward and also raises a warning that you're not doing anything with the plug other than instantiating it. So I propose:

1. Create the plug subclass
2. Instantiate
3. Call .register()

This keeps the most simplicity and ease of use possible while eliminating the error.

Related branches

Avi Romanoff (aroman)
summary: Have a "register" function instead of putting connection logic into
- construcotr
+ constructor
Changed in libpantheon:
status: New → Confirmed
Avi Romanoff (aroman)
Changed in libpantheon:
status: Confirmed → Invalid
status: Invalid → In Progress
Avi Romanoff (aroman)
Changed in libpantheon:
status: In Progress → Fix Released
assignee: nobody → Avi Romanoff (aroman)
importance: Undecided → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.