Incorrect variable causes trouble if an attempted claim return action fails

Bug #821229 reported by Michael Peters
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
Declined for Main by Jason Stephenson
2.0
Fix Released
Undecided
Unassigned
2.1
Fix Released
Undecided
Unassigned

Bug Description

Discovered that we get the error below when marking an item claimed returned that prevented the actual failure reason from being displayed. After changing the "E" to the correct "robj" variable we were then able to see the actual reason why the attempted claim return action failed (in this case, the asset.copy had been deleted!).

Please open a helpdesk ticket and include the following text:

Thu Aug 04 2011 17:34:38 GMT-0400 (Eastern Daylight Time)

The items were not likely marked Claimed Returned.

{
"message":"E is not defined",
"fileName":"http://evergreen.lib.in.us/xul/rel_2_0_4/server/patron/items.js",
"lineNumber":525,
"stack":"(1)@http://evergreen.lib.in.us/xul/rel_2_0_4/server/patron/items.js:525\n(
[
object XULCommandEvent
]
)@http://evergreen.lib.in.us/xul/rel_2_0_4/server/patron/items.js:156\n",
"name":"ReferenceError

Tags: staffclient
Revision history for this message
Michael Peters (mrpeters) wrote :

Thanks much to Jason Etheridge for committing the fix and thanks to Thomas Berezansky for discovering the incorrect variable!

http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=04008a5bece9c12d2e6ce48ed7ed11eb5d537289

Changed in evergreen:
status: New → Fix Committed
importance: Undecided → Low
tags: added: staffclient
Revision history for this message
Jason Etheridge (phasefx) wrote :

Also pushed to rel_2_1 and rel_2_0

Changed in evergreen:
milestone: none → 2.1.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.