duplicate methods for safely opening branches
Bug #820453 reported by
Jelmer Vernooij
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Jelmer Vernooij | ||
Bug Description
Launchpad currently has two different functions for safely opening branches, each with slightly different semantics. It would be nice if there was just one.
They are:
lp.codehosting.
lp.codehosting.
Related branches
lp:~jelmer/launchpad/820453-safe-open-dup
- Steve Kowalik (community): Approve (code)
-
Diff: 466 lines (+90/-179)9 files modifiedlib/launchpad_loggerhead/app.py (+1/-1)
lib/lp/code/interfaces/branch.py (+1/-1)
lib/lp/code/model/branch.py (+1/-1)
lib/lp/code/model/tests/test_branch.py (+3/-3)
lib/lp/codehosting/bzrutils.py (+0/-74)
lib/lp/codehosting/puller/tests/test_errors.py (+5/-2)
lib/lp/codehosting/safe_open.py (+30/-0)
lib/lp/codehosting/tests/test_bzrutils.py (+0/-92)
lib/lp/codehosting/tests/test_safe_open.py (+49/-5)
| tags: | removed: code-import |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-untestable removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r13652 <http://