pt-query-digest --[no]zero-bool doesn't work
Bug #820104 reported by
Daniel Nichter
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Low
|
Daniel Nichter |
Bug Description
pt-query-digest --[no]zero-bool doesn't work because the option isn't used. This was detected by util/check-tool.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/fix-zero-bool-bug-820104
- Daniel Nichter: Approve
-
Diff: 84 lines (+4/-13)3 files modifiedbin/pt-query-digest (+2/-8)
lib/QueryReportFormatter.pm (+2/-4)
t/lib/QueryReportFormatter.t (+0/-1)
Changed in percona-toolkit: | |
status: | In Progress → Fix Committed |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Iirc, mk-query-digest used to print bools like "Full scan %0", i.e. just one value, the %true. That could result in "Full scan 0%" because all events were "Full_scan: No". So --no-zero-bool would suppress lines like "Full scan %0". However, the output format changed as early as pt-query-digest 1.0 because now the bools are like "Full scan 0% yes, 100% no". Since both %true(yes) and %false(no) are printed, there are no longer just zero lines, so --[no]zero-bool is useless. The option hasn't worked, so we might as well just remove it from the POD.