pt-query-digest --[no]zero-bool doesn't work

Bug #820104 reported by Daniel Nichter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Toolkit moved to https://jira.percona.com/projects/PT
Fix Released
Low
Daniel Nichter

Bug Description

pt-query-digest --[no]zero-bool doesn't work because the option isn't used. This was detected by util/check-tool.

Related branches

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

Iirc, mk-query-digest used to print bools like "Full scan %0", i.e. just one value, the %true. That could result in "Full scan 0%" because all events were "Full_scan: No". So --no-zero-bool would suppress lines like "Full scan %0". However, the output format changed as early as pt-query-digest 1.0 because now the bools are like "Full scan 0% yes, 100% no". Since both %true(yes) and %false(no) are printed, there are no longer just zero lines, so --[no]zero-bool is useless. The option hasn't worked, so we might as well just remove it from the POD.

Changed in percona-toolkit:
status: New → Confirmed
assignee: nobody → Daniel Nichter (daniel-nichter)
Revision history for this message
Baron Schwartz (baron-xaprb) wrote :

I believe it's OK to remove this option. Let's target it for the next milestone, and during that time, we can write some code in OptionParser.pm to warn when a deprecated option is removed, eg:

--item --zero-bool

deprecated: yes; blah: blah

When such an option is given on the command line or in a file, the tool should print to STDERR something like this:

Warning: option '--zero-bool' is deprecated and will be removed in the next version of Percona Toolkit.

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

This option has been removed in 2.1.2. It wasn't connected to any code anyway, so removing it didn't affect any functionality or output.

tags: added: broken-option
Changed in percona-toolkit:
status: Confirmed → In Progress
milestone: none → 2.1.2
Changed in percona-toolkit:
status: In Progress → Fix Committed
Changed in percona-toolkit:
status: Fix Committed → Fix Released
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-741

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.