OpenStack Compute (nova)

No name 'image' in module 'nova.objectstore'

Bug #820062 reported by Matthew Hooker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Matthew Hooker
OpenStack Compute (nova) 2011.3 "diablo"

Bug Description

see https://jenkins.openstack.org/job/nova-pylint-errors/violations/file/bin/nova-import-canonical-imagestore/?

file bin/nova-import-canonical-imagestore imports 'image' from nova.objectstore and uses the import in the download method

there is no object 'image' under nova.objectstore

nova.objectstore.image should either be implemented or bin/nova-import-canonical-imagestore should be removed

Related branches

lp:~u-matt-h/nova/pylint-fixes
Dan Prince (community): Approve
Soren Hansen (community): Approve
William Wolf (community): Needs Information
Jason Kölker (community): Approve
Diff: 749 lines (+115/-162)
28 files modified
bin/nova-import-canonical-imagestore (+0/-110)
nova/api/openstack/__init__.py (+6/-3)
nova/api/openstack/contrib/floating_ips.py (+1/-1)
nova/api/openstack/create_instance_helper.py (+0/-2)
nova/api/openstack/extensions.py (+5/-1)
nova/compute/api.py (+15/-4)
nova/db/sqlalchemy/api.py (+3/-6)
nova/objectstore/s3server.py (+4/-1)
nova/scheduler/least_cost.py (+2/-1)
nova/scheduler/manager.py (+3/-1)
nova/scheduler/zone_aware_scheduler.py (+2/-2)
nova/tests/api/openstack/test_limits.py (+4/-1)
nova/tests/scheduler/test_scheduler.py (+12/-12)
nova/tests/test_auth.py (+6/-1)
nova/tests/test_compute.py (+6/-3)
nova/tests/test_instance_types_extra_specs.py (+1/-1)
nova/tests/test_libvirt.py (+4/-1)
nova/tests/test_xenapi.py (+18/-0)
nova/virt/fake.py (+1/-1)
nova/virt/hyperv.py (+1/-1)
nova/virt/vmwareapi/io_util.py (+4/-1)
nova/virt/vmwareapi/vif.py (+1/-1)
nova/virt/vmwareapi/vim_util.py (+8/-2)
nova/virt/vmwareapi/vmware_images.py (+5/-1)
nova/virt/vmwareapi_conn.py (+1/-1)
nova/virt/xenapi/vm_utils.py (+1/-1)
nova/virt/xenapi_conn.py (+1/-1)
setup.py (+0/-1)
Revision history for this message
Vish Ishaya (vishvananda) wrote : Re: [Bug 820062] [NEW] No name 'image' in module 'nova.objectstore'

That code is bitrotted and should probably be removed.

Vish

On Aug 2, 2011, at 2:23 PM, Matthew Hooker wrote:

> Public bug reported:
>
> see https://jenkins.openstack.org/job/nova-pylint-
> errors/violations/file/bin/nova-import-canonical-imagestore/?
>
> file bin/nova-import-canonical-imagestore imports 'image' from
> nova.objectstore and uses the import in the download method
>
> there is no object 'image' under nova.objectstore
>
> nova.objectstore.image should either be implemented or bin/nova-import-
> canonical-imagestore should be removed
>
> ** Affects: nova
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are a member of Nova Bug
> Team, which is subscribed to OpenStack Compute (nova).
> https://bugs.launchpad.net/bugs/820062
>
> Title:
> No name 'image' in module 'nova.objectstore'
>
> Status in OpenStack Compute (Nova):
> New
>
> Bug description:
> see https://jenkins.openstack.org/job/nova-pylint-
> errors/violations/file/bin/nova-import-canonical-imagestore/?
>
> file bin/nova-import-canonical-imagestore imports 'image' from
> nova.objectstore and uses the import in the download method
>
> there is no object 'image' under nova.objectstore
>
> nova.objectstore.image should either be implemented or bin/nova-
> import-canonical-imagestore should be removed
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/nova/+bug/820062/+subscriptions

Revision history for this message
Matthew Hooker (u-matt-h) wrote :

okay. I'll own this bug and remove the code.

Changed in nova:
assignee: nobody → Matthew Hooker (u-matt-h)
status: New → In Progress
Matthew Hooker (u-matt-h)
Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → diablo-4
Thierry Carrez (ttx)
Changed in nova:
milestone: diablo-4 → 2011.3
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.