All action buttons should be disabled in unsaved o2m record (popup)

Bug #817019 reported by Xavier (Open ERP)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Web (MOVED TO GITHUB)
Fix Released
Medium
OpenERP R&D Web Team

Bug Description

When o2m record created in list-o2m and not saved yet (because parent has not been saved since record was created), buttons should all be disabled in o2m popup

Demo: Warehouse > Warehouse Management > Internal Moves
1. Create new internal move/picking (can save or not, should not matter)
2. Create new stock move (in o2m list)

Observed: "Confirm" button is clickable (enabled)
Expected: "Confirm" button should not be clickable (disabled) (see GTK client, same bug exists in 6.0 web client so it's going to be wrong as well)

3. Save stock move
4. Reopen stock move (still not saving without saving internal move/picking)

Observed: "Confirm button is still enabled (when there is not an error, which there currently is)
Expected: "Confirm button should still be disabled

5. Save parent (internal move/picking)
6. Reopen stock move again
7. Now button should be enabled

Related branches

Changed in openerp-web:
importance: Low → Medium
Changed in openerp-web:
assignee: Nicolas Vanhoren (OpenERP) (niv-openerp) → OpenERP R&D Web Team (openerp-dev-web)
Changed in openerp-web:
status: Confirmed → In Progress
Revision history for this message
Mohammed Shekha(Open ERP) (msh-openerp) wrote :

Hello,

I have created a merge proposal for 6.0 and the branch is lp:~openerp-dev/openobject-client-web/6.0-bug-6179-msh.

Thanks.

Changed in openerp-web:
status: In Progress → Confirmed
Revision history for this message
Vaibhav Darji (vaibhav-openerp) wrote :

Hello Xavier,

It has been fixed in https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-817019-vda
at revision:1025

Thanks,
vda

Changed in openerp-web:
status: Confirmed → Fix Committed
Revision history for this message
Nicolas Vanhoren (OpenERP) (niv-openerp) wrote :

@vda I took a look at your branch, but that improvement is not sufficient, it's too simple.

I think I'll handle this bug myself, thank you.

Changed in openerp-web:
status: Fix Committed → Confirmed
Changed in openerp-web:
status: Confirmed → In Progress
Revision history for this message
Nicolas Vanhoren (OpenERP) (niv-openerp) wrote :

Now disable the button on every unsaved o2m record.

Changed in openerp-web:
status: In Progress → Fix Released
Changed in openerp-web:
status: Fix Released → Confirmed
Changed in openerp-web:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.