Attach volume fails with NameError: global name 'vol' is not defined

[Rohit Karajgi]

On the latest trunk:
-------------------- >> begin captured logging << --------------------
2011-07-26 07:49:47,488 DEBUG nova.utils [-] backend <module 'nova.db.sqlalchemy.api' from '/home/rohit/nova/diablo/libvirt-negative-tests/nova/db/sqlalchemy/api.pyc'> from (pid=16728) __get_backend /home/rohit/nova/diablo/libvirt-negative-tests/nova/utils.py:417
2011-07-26 07:49:47,627 AUDIT nova.auth.manager [-] Created user fake (admin: True)
2011-07-26 07:49:47,783 AUDIT nova.auth.manager [-] Created project fake with manager fake
2011-07-26 07:49:47,860 ERROR nova.exception [-] Uncaught exception
(nova.exception): TRACE: Traceback (most recent call last):
(nova.exception): TRACE: File "/home/rohit/nova/diablo/libvirt-negative-tests/nova/exception.py", line 97, in wrapped
(nova.exception): TRACE: return f(*args, **kw)
(nova.exception): TRACE: File "/home/rohit/nova/diablo/libvirt-negative-tests/nova/virt/libvirt/connection.py", line 339, in attach_volume
(nova.exception): TRACE: self._get_volume_device_info(vol['device_path'])
(nova.exception): TRACE: NameError: global name 'vol' is not defined
(nova.exception): TRACE:
--------------------- >> end captured logging << ---------------------

[Rohit Karajgi (rohitk)]

This bug is present in /nova/virt/libvirt/connection.py (revision 1326)

[Rohit Karajgi (rohitk)]

Simple fix is to use the input parameter 'device_path' instead of the 'vol' dictionary device path.

[Vish Ishaya (vishvananda)]

This is an important bug. Please submit a merge prop if you have a fix.

[Vish Ishaya (vishvananda)]

ah i see it. i will submit a hot-fix

[Rohit Karajgi (rohitk)]

Ok. Thanks Vish!