systemtap on Oneiric breaks because of kernel commit 449a66fd1fa75d36dca917704827c40c8f416bca

[Colin Ian King]

SystemTap on Oneiric fails to build any systemtap scripts because of Kernel commit 449a66fd1fa75d36dca917704827c40c8f416bca, namely:

commit 449a66fd1fa75d36dca917704827c40c8f416bca
Author: Richard Weinberger <email address hidden>
Date: Thu May 12 15:11:12 2011 +0200

    x86: Remove warning and warning_symbol from struct stacktrace_ops

    Both warning and warning_symbol are nowhere used.
    Let's get rid of them.

    Signed-off-by: Richard Weinberger <email address hidden>
    Cc: Oleg Nesterov <email address hidden>
    Cc: Andrew Morton <email address hidden>
    Cc: Huang Ying <email address hidden>
    Cc: Soeren Sandmann Pedersen <email address hidden>
    Cc: Namhyung Kim <email address hidden>
    Cc: x86 <email address hidden>
    Cc: H. Peter Anvin <email address hidden>
    Cc: Thomas Gleixner <email address hidden>
    Cc: Robert Richter <email address hidden>
    Cc: Paul Mundt <email address hidden>
    Link: http://<email address hidden>
    Signed-off-by: Frederic Weisbecker <email address hidden>

diff --git a/arch/x86/include/asm/stacktrace.h b/arch/x86/include/asm/stacktrace.h
index d7e89c8..70bbe39 100644
--- a/arch/x86/include/asm/stacktrace.h
+++ b/arch/x86/include/asm/stacktrace.h
@@ -37,9 +37,6 @@ print_context_stack_bp(struct thread_info *tinfo,
 /* Generic stack tracer with callbacks */

 struct stacktrace_ops {
- void (*warning)(void *data, char *msg);
- /* msg must contain %s for the symbol */
- void (*warning_symbol)(void *data, char *msg, unsigned long symbol);
        void (*address)(void *data, unsigned long address, int reliable);
        /* On negative return stop dumping */
        int (*stack)(void *data, char *name);

This removes warning and warning_symbol from stacktrace_ops which causes /usr/share/systemtap/runtime/stack.c to fail to compile. Either reverting this commit *OR* removing the .warning and .warning_symbol initialisation in /usr/share/systemtap/runtime/stack.c and also print_stack_warning() and print_stack_warning_symbol().

[Frank Ch. Eigler (fche)]

Fixed in systemtap upstream; also in release 1.6.

commit 0bbb80098decc9c4c43a1800538007d86b600bba
Author: Josh Stone <email address hidden>
Date: Tue Jun 7 11:23:13 2011 -0700

    stapconf: Conditionalize stacktrace_ops.warning{,_symbol}

[Colin Ian King (colin-king)]

This bug was fixed in the package systemtap - 1.4-1ubuntu2, bug LP#838205

---------------
systemtap (1.4-1ubuntu2) oneiric; urgency=low

  * debian/patches/fix-compile-warning: Apply upstream fix for failure to
    compile tapsets due to kernel change. (LP: #838205)
  * debian/patches/no-werror.patch: Remove -Werror from CFLAGS to avoid
    new variable-set-but-not-used errors when building.
 -- Ubuntu <email address hidden> Wed, 31 Aug 2011 16:06:54 +0000