fix song menu rating

[Scott Ringwelski]

along with many other things, gtk3 brought a problem to the song menu rating menu item

[Scott Ringwelski (sgringwe)]

ricotz,

since you were the one who added this functionality do you think you could look into the current problem that came from the gtk3 switch. the star is painted in the image space on the left side of the menu item...

thanks,
Scott

[Rico Tzschichholz (ricotz)]

i didnt add or contributed this feature. ;)

[Scott Ringwelski (sgringwe)]

hmmm xapantu was that you then?

[Rico Tzschichholz (ricotz)]

@scott: You really need to start using bazaar properly to keep track of such things. Like if there are merge proposals use "bzr merge ..." which will give you a nice history of contributors for each single line of code. ;-)
You can also define the author while committing a patch-file with "bzr commit --author=...".

[Scott Ringwelski (sgringwe)]

i'm fairly confident I did use merge for this. i'm just too lazy to find the merge page to check who did it :o

[Rico Tzschichholz (ricotz)]

bzr log -n0 -r174
bzr log -n0 -r271

[xapantu (xapantu)]

Hum, I don't think I did anything for the gtk3 port of BeatBox.

[xapantu (xapantu)]

Ah, sorry, I only received the mails from #3, I didn't think there was any other ones -.-
Yes, it was me, I will take a look ;)

[Scott Ringwelski (sgringwe)]

pushing this back to 0.3

[Scott Ringwelski (sgringwe)]

Victor, I still have problems with the ratingmenu in elementary and radiance (didn't try any other themes)

[Victor Martinez (victored)]

My bad, I didn't include the fix for this in my branch.

[Scott Ringwelski (sgringwe)]

Still having issues with elementary, but ambiance and radiance both worked.

[Victor Martinez (victored)]

This is obviously a bug in GTK, since we can't have custom transparent widgets in menuitems. This problem can be seen in many other places (ubuntu's sound menu for instance) and is solved by using background-color instead of background-image to theme menus.

[Danielle Foré (danrabbit)]

applied the workaround in egtk, this does not solve the problem with slingshot unfortunately.