0.9.2 «Put» plugin sends window in wrong direction

[Chris Swetenham]

Tested using 9 horizontal viewports on Maverick and Natty.
Currently using compiz-fusion-plugins-main 0.9.4+bzr20110527-0ubuntu1~natty1.

When on viewport 1, using the Put plugin's 'send to viewport' command to send to viewport 8 will send the window in the wrong direction where it will get stuck past the edge of the screen - it never reaches viewport 8. Other combinations have the similar effects.

The issue seems to be in put.cpp function getDistance, case PutViewport. The calculation assumes the viewports wrap and it can send windows around 'the short way', but this doesn't work. I have commented out lines as follows:

/* take the shortest horizontal path to the destination viewport */
 hDirection = (vpX - s->vp ().x ());
// if (hDirection > (int) s->vpSize ().width () / 2)
// hDirection = (hDirection - s->vpSize ().width ());
// else if (hDirection < - ((int) s->vpSize ().width ()) / 2)
// hDirection = (hDirection + s->vpSize ().width ());

and this seems to fix the issue.