QtScript required even if ENABLE_SCRIPTING=0

[Chris Young]

I'm trying to cross-compile Stellarium for a platform which does not implement QtScript. I have set ENABLE_SCRIPTING to 0 in CMakeLists.txt, however it appears this does not remove the dependency on QtScript:

Scanning dependencies of target StelGuiLib
[ 6%] Building CXX object src/CMakeFiles/StelGuiLib.dir/gui/StelGui.cpp.obj
In file included from /home/Chris/stellarium-0.11.0/src/gui/StelGui.cpp:50:
/home/Chris/stellarium-0.11.0/src/scripting/StelScriptMgr.hpp:24:20: error: QtSc
ript: No such file or directory
In file included from /home/Chris/stellarium-0.11.0/src/gui/StelGui.cpp:50:
/home/Chris/stellarium-0.11.0/src/scripting/StelScriptMgr.hpp:152: error: 'QScri
ptEngine' does not name a type
/home/Chris/stellarium-0.11.0/src/gui/StelGui.cpp: In member function 'virtual v
oid StelGui::init(QGraphicsWidget*, StelAppGraphicsWidget*)':
/home/Chris/stellarium-0.11.0/src/gui/StelGui.cpp:331: error: 'class StelMainGra
phicsView' has no member named 'getScriptMgr'
/home/Chris/stellarium-0.11.0/src/gui/StelGui.cpp: In member function 'void Stel
Gui::quit()':
/home/Chris/stellarium-0.11.0/src/gui/StelGui.cpp:498: error: 'class StelMainGra
phicsView' has no member named 'getScriptMgr'
/home/Chris/stellarium-0.11.0/src/gui/StelGui.cpp: In member function 'void Stel
Gui::increaseScriptSpeed()':
/home/Chris/stellarium-0.11.0/src/gui/StelGui.cpp:717: error: 'class StelMainGra
phicsView' has no member named 'getScriptMgr'
/home/Chris/stellarium-0.11.0/src/gui/StelGui.cpp:717: error: 'class StelMainGra
phicsView' has no member named 'getScriptMgr'
/home/Chris/stellarium-0.11.0/src/gui/StelGui.cpp: In member function 'void Stel
Gui::decreaseScriptSpeed()':
/home/Chris/stellarium-0.11.0/src/gui/StelGui.cpp:722: error: 'class StelMainGra
phicsView' has no member named 'getScriptMgr'
/home/Chris/stellarium-0.11.0/src/gui/StelGui.cpp:722: error: 'class StelMainGra
phicsView' has no member named 'getScriptMgr'
/home/Chris/stellarium-0.11.0/src/gui/StelGui.cpp: In member function 'void Stel
Gui::setRealScriptSpeed()':
/home/Chris/stellarium-0.11.0/src/gui/StelGui.cpp:727: error: 'class StelMainGra
phicsView' has no member named 'getScriptMgr'
make[2]: *** [src/CMakeFiles/StelGuiLib.dir/gui/StelGui.cpp.obj] Error 1
make[1]: *** [src/CMakeFiles/StelGuiLib.dir/all] Error 2
make: *** [all] Error 2

If scripting is disabled, QtScript should not be required at all.

[Alexander Wolf (alexwolf)]

Try use -DDISABLE_SCRIPTING

[Chris Young (chris-0zxv)]

I have tried that, but ENABLE_SCRIPTING 0 in CMakeLists sets it anyway so it makes no difference.

It appears that StelScriptMgr.hpp includes QtScript regardless, and the include for StelScriptMgr.hpp in StelGui.cpp is not within any #defines. Unfortunately it doesn't look as easy as just taking out this include.

[Alexander Wolf (alexwolf)]

A fix has been committed as revision 5117 of the trunk branch in Stellarium's Bazaar repository at Launchpad:
http://bazaar.launchpad.net/~stellarium/stellarium/trunk/revision/5117