[Trunk] document_ftp module is not install with the latest trunk code.

[Vinay Rana (OpenERP)]

when I tried to install this module I did face following traceback:

2011-07-15 15:49:10,602][?] ERROR:web-services:Uncaught exception
Traceback (most recent call last):
  File "/home/vra/workspace/trunk/server/openerp/osv/osv.py", line 118, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "/home/vra/workspace/trunk/server/openerp/osv/osv.py", line 172, in execute
    res = self.execute_cr(cr, uid, obj, method, *args, **kw)
  File "/home/vra/workspace/trunk/server/openerp/osv/osv.py", line 163, in execute_cr
    return getattr(object, method)(cr, uid, *args, **kw)
  File "/home/vra/workspace/trunk/server/openerp/addons/base/module/wizard/base_module_upgrade.py", line 44, in fields_view_get
    res = super(base_module_upgrade, self).fields_view_get(cr, uid, view_id=view_id, view_type=view_type, context=context, toolbar=toolbar,submenu=False)
  File "/home/vra/workspace/trunk/server/openerp/osv/orm.py", line 1917, in fields_view_get
    WHERE id=%s""", (view_id,))
  File "/home/vra/workspace/trunk/server/openerp/sql_db.py", line 153, in wrapper
    return f(self, *args, **kwargs)
  File "/home/vra/workspace/trunk/server/openerp/sql_db.py", line 213, in execute
    res = self._obj.execute(query, params)
InternalError: current transaction is aborted, commands ignored until end of transaction block

[Bhumika Shrimali (sbh-openerp)]

hello,

It has been fixed in lp:~openerp-dev/openobject-addons/trunk-bug-810983-sbh
Revision ID: <email address hidden>
Revision num: 4890.

[Fabien (Open ERP) (fp-tinyerp)]

I reopen the bug as the fix was not correct: we can not put cr;commit on tests as all tests must be rollbacked.

[xrg (xrg)]

On Saturday 24 September 2011, you wrote:
> I reopen the bug as the fix was not correct: we can not put cr;commit on
> tests as all tests must be rollbacked.

Well, this is _not_ possible for the FTP, WebDAV etc. tests[1].
You see, these tests open FTP client connections to the server, which have
their own atomic transactions.

So, a part of the test like:
   !record {model: ir.attachment, id: foo_file1}:
      .....

will not be visible to the FTP client *unless* a cr.commit() is performed.

It is true that we don't want to leave garbage from these tests behind. The
only thing we could do about that was to put all the attachments/folders under
some temporary-testing folders and cleanup at the end of the YAML test.

[1] including any future tests in modules with external connectivity

--
Say NO to spam and viruses. Stop using Microsoft Windows!

[tfr (Openerp) (tfr)]

Actually the module is installing but the ftp server is not launch. the connection is refused even on localhost

[Bhumika Shrimali (sbh-openerp)]

hello,

It has been fixed in lp:~openerp-dev/openobject-addons/trunk-bug-document_ftp-sbh.

Revision ID: <email address hidden>
Revision 6084.

I have put "document_ftp_test4.yml'," yml file in comment because I have send the new mp for that yml file.

Thanks

[Olivier Dony (Odoo) (odo-openerp)]

I've double-checked at server r.4061 with addons r.6587 and the document_ftp module now seems to install and start fine, so we can close this bug - no further changes seem to be needed.

Thanks for your efforts