Remove version from href, incorrect RE
Bug #810149 reported by
Alex Meade
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Undecided
|
Stephanie Reese |
Bug Description
in nova/api/
the remove_
new_href = re.sub(
this incorrectly handles any href with a "/v" in it
it should be:
new_href = re.sub(
or
new_href = re.sub(
depending if the href ends in '/'
Related branches
lp:~reese-sm/nova/version-href-regex-lp810149
- Devin Carlen (community): Approve
- Rick Harris (community): Approve
-
Diff: 82 lines (+35/-3)3 files modifiedAuthors (+1/-0)
nova/api/openstack/common.py (+10/-3)
nova/tests/api/openstack/test_common.py (+24/-0)
Changed in nova: | |
assignee: | nobody → Stephanie Reese (reese-sm) |
Changed in nova: | |
status: | New → In Progress |
Changed in nova: | |
status: | In Progress → Fix Committed |
Changed in nova: | |
milestone: | none → diablo-3 |
Changed in nova: | |
milestone: | diablo-3 → 2011.3 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
If a version appears more than once in the href (would that ever happen?), I'm assuming this function should remove only the first occurrence. Please let me know if that's not the case.