Acquisitions: Entire Selection List not transferring when Creating a Purchase order

[Mary Llewellyn]

Evergreen version: 2.0.6
OpenSRF version: 2.0.0
PostgreSQL version: 8.4
Linux distribution: Ubuntu 10.04 Lucid

When a selection list has more than 20 lineitems, the entire list does not go to the purchase order, even if "All lineitems" is the selected choice on the window that pops up when you choose "Create purchase order." In one case, a selection list of 31 item resulted in 20 items tranferring; in another, a selection list of 58 lines resulted in 30 transferring.

[Ben Shum (bshum)]

It would appear that "all lineitems" only refers to the 20 line items that appear on the first page of line items in a selection list. If there are subsequent pages with additional line items, they are not moved over to the purchase order. You can view the rest of a selection list by using the "Next" button, but there does not seem to be any way to select items from different pages of a selection list to pass to the purchase order creation.

[Lebbeous Fogle-Weekley (lebbeous)]

I think the commit at the head of the following branch thoroughly addresses this issue. Please see the commit message.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/senator/lp-810030

[Ben Shum (bshum)]

Wow, senator++ indeed! Tested this on one of our test systems and appears to not break anything. As expected, the loading process for a selection list of line items to transfer to a purchase order was a beast to process (and my client hung for a bit as it was thinking and processing), but all line items transferred to the purchase order in my test (131 line items to PO).

I notice that in your comments for the code, there was this line "XXX memory leak waiting to happen?" added to li_table_pager.js. Is that a general warning about very large PO creation being troublesome for the system down the road?

Either way, senator++

[Mike Rylander (mrylander)]

Confirmed this cherrypicks into 2.1 and 2.0, so I've done that.

[James Fournie (jfournie)]

Guess I won't try and fix this then :)

[Lebbeous Fogle-Weekley (lebbeous)]

Thanks for the feedback all.

To answer Ben's question, the comment about a memory leak actually had to do with circular references. An instance of LiTablePager will have references to an instance of AcqLiTable, and the latter will have references to the former, too.

After refreshing myself on the topic of Javascript garbage collection, I apparently had too little faith in it, and circular references should be no problem.