.profile is read twice if byobu-launcher-install is used

Bug #809525 reported by Scott Moser
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu (Ubuntu)
Fix Released
High
Unassigned

Bug Description

if the user sets byobu to run via byobu-launcher-install, then their .profile will be sourced twice.

I'd suggest in byobu-launcher-install to have:
install_launcher() {
    printf "BYOBU_SOURCED_PROFILE=1 ; . \$(which byobu-launch)\n" >> "$1"
}

Also, not a terribly big deal, but I do not think you need the 'which' statement at all.
instead, just:

BYOBU_SOURCED_PROFILE=1 ; . byobu-launch

Note, i notice this because I run keychain from .profile, and i can see it run twice on login.

ProblemType: Bug
DistroRelease: Ubuntu 11.10
Package: byobu 4.17-0ubuntu1
ProcVersionSignature: Ubuntu 3.0-2.3-generic 3.0.0-rc4
Uname: Linux 3.0-2-generic x86_64
Architecture: amd64
Date: Tue Jul 12 15:25:37 2011
EcryptfsInUse: Yes
InstallationMedia: Ubuntu 10.04 "Lucid Lynx" - Beta amd64 (20100318)
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: byobu
UpgradeStatus: Upgraded to oneiric on 2010-11-15 (238 days ago)

Revision history for this message
Scott Moser (smoser) wrote :
Changed in byobu (Ubuntu):
importance: Undecided → High
status: New → In Progress
Changed in byobu (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (6.9 KiB)

This bug was fixed in the package byobu - 4.18-0ubuntu1

---------------
byobu (4.18-0ubuntu1) oneiric; urgency=low

  [ Dustin Kirkland ]
  * usr/bin/byobu, usr/bin/byobu-status:
    - remove some redundancies
  * usr/bin/byobu, usr/bin/byobu-config, usr/bin/byobu-ctrl-a,
    usr/bin/byobu-disable, usr/bin/byobu-launcher, usr/bin/byobu-quiet,
    usr/bin/byobu-reconnect-sockets, usr/bin/byobu-select-profile,
    usr/bin/byobu-select-session, usr/lib/byobu/.constants:
    - use a BYOBU_BACKEND environment variable, to support both screen
      and tmux
  * etc/byobu/socketdir, usr/bin/byobu, usr/lib/byobu/date,
    usr/lib/byobu/notify_osd, usr/share/byobu/keybindings/f-keys,
    usr/share/byobu/keybindings/screen-escape-keys,
    usr/share/byobu/profiles/common, usr/share/byobu/profiles/NONE,
    usr/share/byobu/profiles/tmux, usr/share/byobu/windows/common:
    - use a BYOBU_BACKEND environment variable, to support both screen
      and tmux
  * usr/lib/byobu/.common, usr/lib/byobu/.constants:
    - ensure that libraries only get included once
  * === removed directory usr/sbin, usr/sbin/byobu-classroom =>
    experimental/byobu-classroom:
    - move the classroom to experimental (about to be an ensemble formula)
  * etc/byobu/backend, usr/lib/byobu/.constants:
    - add support for storing byobu backend configuration (screen|tmux)
  * debian/control: start suggesting tmux
  * usr/bin/byobu, usr/lib/byobu/.constants:
    - support tmux -V version
  * usr/lib/byobu/.shutil:
    - update ec2 detection method
  * === added directory usr/share/byobu/status, configure.ac,
    etc/byobu/statusrc, experimental/byobu-status-all => usr/bin/byobu-
    statusd, Makefile.am, usr/bin/byobu-janitor, usr/bin/byobu-status-
    print, usr/bin/Makefile.am, usr/lib/byobu/color,
    usr/lib/byobu/.constants, usr/lib/byobu/Makefile.am,
    usr/lib/byobu/.shutil, usr/share/byobu/profiles/common,
    usr/share/byobu/status/1, usr/share/byobu/status/2,
    usr/share/byobu/status/3, usr/share/byobu/status/4,
    usr/share/byobu/status/Makefile.am:
    - add shared configurations for status ordering
    - install symlinks to status ordering
    - add status script for status colors
    - move color function to shared utils
    - add stub for tmux color support
    - add byobu-statusd, daemon to cache and update status information in the
      run directory as the information expires
    - add byobu-status-print, script to concatenate status per ordered
      configuration
    - move byobu backend support below BYOBU_CONFIG_DIR determination
    - move status frequencies to a shared utility function
    - drop the backtick commands for all the individual status functions
    - add the backtick commands for the 4 quadrants of status
    - update the hardstatus line accordingly
  * usr/bin/byobu-select-session, usr/lib/byobu/.common,
    usr/lib/byobu/.constants, usr/lib/byobu/.dirs,
    usr/lib/byobu/Makefile.am, usr/share/byobu/profiles/common,
    usr/share/byobu/status/1, usr/share/byobu/status/2:
    - fix string bug in select session
    - re-add a couple of necessary backticks
    - update caption line to use new statusd cache
    - significantly reduce the numb...

Read more...

Changed in byobu (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.