not possible change the packaging in sale order

[bruno bottacini]

i install sale and product_visible_discount, make a product with two or more packaging, a new sale order and in a sale order line after i choose my product i can't change the packaging.

i think the problem is in the file product_visible_discount/product_visible_discount.py

74c74
< lang, update_tax,date_order,fiscal_position=fiscal_position,flag=flag)
---
> lang, update_tax,date_order,packaging,fiscal_position=fiscal_position,flag=flag)

openerp v6.02
ubuntu lucid 64

[bruno bottacini (bruno-bottacini)]

my problem is not to make packaging field empty, but change from a packaging to another packaging

[bruno bottacini (bruno-bottacini)]

product_visible_discount/product_visible_discount.py

 71 res=super(sale_order_line, self).product_id_change(cr, uid, ids, pricelist, product, qty,
 72 uom, qty_uos, uos, name, partner_id,
 73 lang, update_tax,date_order,fiscal_position=fiscal_position,flag=flag)

in this function call is missing the parameter packaging

[Paulius Sladkevičius @ hbee (komsas)]

Hello,

I see that in the duplicate bug #795487 this problem is not solved. It is critical bug if you want to use this module (product_visible_discount) and sale order line packaging. I'm adding Bruno patch in the separate file.

[Amit Parik (amit-parik)]

Hello,

I am confirming this issue which is not fixed previously posted bug lp:795487.

I have studied the fixes from following link and found the the problem in fixed code which is the "packaging" argument missing in product_id_change method of sale_order_line line number74 and attached a patch is seems good.

http://bazaar.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-795487-uco/revision/4820.

Thanks.

[Bharat Devnani (Open ERP) (bde-openerp)]

Hello bruno bottacini,

Thanks for your time and contribution, i have checked your patch and its work fine. Following are the Revision ID and Number of the bug :

Revision ID : <email address hidden>
Revision Number : 4956

The Solution will be merged in addons soon.

Thanks & Regards,
Devnani Bharat R.

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

Bharat

Bug should be fixed in the branch mention in comment 4.

Thanks,
Mustufa

[Ujjvala Collins (uco-openerp)]

Hello bruno,

The fix has been committed on the branch mentioned in the comment #4 with revision id 4821 <email address hidden>. I have applied the changes suggested in the comment #3. Thanks Paulius Sladkevičius for that.

This will be merged into trunk-addons soon.

Thanks,
Ujjvala

[qdp (OpenERP) (qdp)]

fix released in revision 5423.

thanks