landscape-client should have a native Upstart job

[Mark Russell]

I've attached a proposed script. Due to the way Upstart works, I don't think there's a need to manage the PID file. However, I'm a little less sure about whether the just-in-case cleaning of /var/lib/landscape/client/sockets is necessary. Might still be the case.

Also: again, due to Upstart, it makes more sense to run landscape-client in the foreground rather than daemonize. It's simpler that way. The only downside is that it will emit "started landscape-client" as soon as it is executed. In some cases this is a problem. The started event might fire before the daemon has fully initialized or started listening. Since landscape-client does not listen, and as far as I know, has no reverse dependencies, this should be no problem.

[Mark Russell (marrusl)]

Looks like landscape-config calls the old init script directly to restart:

"sh: /etc/init.d/landscape-client: not found
Couldn't restart the Landscape client.
This machine will be registered with the provided details when the client runs."

[Andreas Hasenack (ahasenack)]

It's lacking a symlink /etc/init.d/landscape-client -> /lib/init/upstart-job

[🤖 Landscape Builder (landscape-builder)]

This bug has not seen any activity in the last 6 months, so it is being automatically closed.

If you are still experiencing this issue, please feel free to re-open.

Landscape Team