make uninstall misses a few things

Bug #806787 reported by Max
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Marlin
Invalid
Undecided
Unassigned

Bug Description

First off, I wish there were somewhere that I could express just how grateful I am that this file manager exists. It is exactly what I want in a file manager, and doesn't come with / force me into all kinds of things that I don't want.

I always tell configure to set my prefix to a temporary directory somewhere so I can see how well something uninstalls when I don't have a readily available Arch package for it.
In doing so on this, I found that it leaves files all over PREFIX-DIR/share such as a .desktop and locale files
I don't really know how uninstalling is supposed to handle these, but I would assume when you run "make uninstall" you want it to remove everything it installs with "make install" which it fails to in this instance.

On a side note that I'm not sure is a bug / is a bug with marlin; when compiling using the latest git version of the vala compiler, marlin segfaults on startup. If requested, I'll file this as a separate bug with a backtrace I have saved.

Thanks again for the awesome file manager. +1 doing things right.

Tags: make uninstall
Revision history for this message
Brett Bohnenkamper (kittykatt++) wrote :

Max and I have been discussing this new file manager on our IRC network for that last 20 minutes and both of us really love it. I would also like to mention a +1 on this bug as I attempted to do the same thing and resulted in leftover files when executing `make uninstall`.

Revision history for this message
Cody Garver (codygarver) wrote :

I think this will fix it. Goes in marlin/cmake/uninstall.cmake

Revision history for this message
ammonkey (am-monkeyd) wrote :

Hello, we switched from autotools to cmake a few days ago, make uninstall is not in the spirit of cmake .(http://www.vtk.org/Wiki/CMake_FAQ#Can_I_do_.22make_uninstall.22_with_CMake.3F)
The list of installed files is stored in install_manifest.txt in the build directory.

As the faq point out to remove the installed installed you could use the following command:
xargs rm < install_manifest.txt

Thx for your support guys and sorry for the late answer.

Revision history for this message
ammonkey (am-monkeyd) wrote :

About the vala-git yes there s was a time vala-git was highly unstable and make marlin crash while everything was ok with the stable 0.12 version. Should be sorted now.

Changed in marlin:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.