byobu-launch shopt error when using zsh

Bug #806609 reported by Abe Voelker
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu
Fix Released
Low
Unassigned
byobu (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

I have zsh set as my login shell. When I launch byobu, I see the following error:

`/usr/local/bin/byobu-launch:39: command not found: shopt`

I believe this is because `shopt` is bash-specific. I've attached a patch that uses `setopt` if the user is using zsh.

I'm still having some other issues launching byobu from zsh, so maybe this whole bug is moot as I'm just doing it the Wrong Way. But, thought I'd throw it out there.

Also, I'm not sure what the `|| true` is accomplishing, but I'm not a shell scripting master so I left it there.

Tags: patch zsh
Revision history for this message
Abe Voelker (abevoelker) wrote :
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Hi Abe,

Thanks a lot for the bug and the patch! I'm committing a slightly modified version now.

I don't use zsh personally, but Byobu should certainly work just as well with zsh. Please file any other bugs here that prevent byobu from working properly on zsh (hints appreciated!).

Changed in byobu:
status: New → In Progress
importance: Undecided → Low
Changed in byobu (Ubuntu):
status: New → Fix Committed
Changed in byobu:
status: In Progress → Fix Committed
Changed in byobu (Ubuntu):
importance: Undecided → Low
tags: added: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (6.9 KiB)

This bug was fixed in the package byobu - 4.18-0ubuntu1

---------------
byobu (4.18-0ubuntu1) oneiric; urgency=low

  [ Dustin Kirkland ]
  * usr/bin/byobu, usr/bin/byobu-status:
    - remove some redundancies
  * usr/bin/byobu, usr/bin/byobu-config, usr/bin/byobu-ctrl-a,
    usr/bin/byobu-disable, usr/bin/byobu-launcher, usr/bin/byobu-quiet,
    usr/bin/byobu-reconnect-sockets, usr/bin/byobu-select-profile,
    usr/bin/byobu-select-session, usr/lib/byobu/.constants:
    - use a BYOBU_BACKEND environment variable, to support both screen
      and tmux
  * etc/byobu/socketdir, usr/bin/byobu, usr/lib/byobu/date,
    usr/lib/byobu/notify_osd, usr/share/byobu/keybindings/f-keys,
    usr/share/byobu/keybindings/screen-escape-keys,
    usr/share/byobu/profiles/common, usr/share/byobu/profiles/NONE,
    usr/share/byobu/profiles/tmux, usr/share/byobu/windows/common:
    - use a BYOBU_BACKEND environment variable, to support both screen
      and tmux
  * usr/lib/byobu/.common, usr/lib/byobu/.constants:
    - ensure that libraries only get included once
  * === removed directory usr/sbin, usr/sbin/byobu-classroom =>
    experimental/byobu-classroom:
    - move the classroom to experimental (about to be an ensemble formula)
  * etc/byobu/backend, usr/lib/byobu/.constants:
    - add support for storing byobu backend configuration (screen|tmux)
  * debian/control: start suggesting tmux
  * usr/bin/byobu, usr/lib/byobu/.constants:
    - support tmux -V version
  * usr/lib/byobu/.shutil:
    - update ec2 detection method
  * === added directory usr/share/byobu/status, configure.ac,
    etc/byobu/statusrc, experimental/byobu-status-all => usr/bin/byobu-
    statusd, Makefile.am, usr/bin/byobu-janitor, usr/bin/byobu-status-
    print, usr/bin/Makefile.am, usr/lib/byobu/color,
    usr/lib/byobu/.constants, usr/lib/byobu/Makefile.am,
    usr/lib/byobu/.shutil, usr/share/byobu/profiles/common,
    usr/share/byobu/status/1, usr/share/byobu/status/2,
    usr/share/byobu/status/3, usr/share/byobu/status/4,
    usr/share/byobu/status/Makefile.am:
    - add shared configurations for status ordering
    - install symlinks to status ordering
    - add status script for status colors
    - move color function to shared utils
    - add stub for tmux color support
    - add byobu-statusd, daemon to cache and update status information in the
      run directory as the information expires
    - add byobu-status-print, script to concatenate status per ordered
      configuration
    - move byobu backend support below BYOBU_CONFIG_DIR determination
    - move status frequencies to a shared utility function
    - drop the backtick commands for all the individual status functions
    - add the backtick commands for the 4 quadrants of status
    - update the hardstatus line accordingly
  * usr/bin/byobu-select-session, usr/lib/byobu/.common,
    usr/lib/byobu/.constants, usr/lib/byobu/.dirs,
    usr/lib/byobu/Makefile.am, usr/share/byobu/profiles/common,
    usr/share/byobu/status/1, usr/share/byobu/status/2:
    - fix string bug in select session
    - re-add a couple of necessary backticks
    - update caption line to use new statusd cache
    - significantly reduce the numb...

Read more...

Changed in byobu (Ubuntu):
status: Fix Committed → Fix Released
Changed in byobu:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Patches

Remote bug watches

Bug watches keep track of this bug in other bug trackers.