Multiprocess nova-api does not handles SIGTERM correctly.

[Nikolay Sokolov]

In current implementation, nova-api shuts down correctly only by keyboard interrupt. If we kill main nova-api process by SIGTERM, child processes won't stop, so that breaks some init scripts.

[Nikolay Sokolov (chemikadze)]

Manual reproducing of bug.

[Thierry Carrez (ttx)]

That may explain why my laptop does not shut down correctly when nova is running :)
Could you propose your branch for merging ?

[Nikolay Sokolov (chemikadze)]

I was told that now new merge proposals will be approved only with tests. Whether i write some test first, or this case doesn't need it?

[Thierry Carrez (ttx)]

A test case is always better... though if you have no idea on how to cover that with a unittest, you can propose for merging and ask the reviewers for suggestions.

[Brian Lamar (blamar)]

Great catch, diagnosis, and fix. I have a small suggestion which I've proposed for merge into your branch if you're open to it. Otherwise I don't think this requires an automated test and should be fine to merge.

[Andrey Brindeyev (abrindeyev)]

Brian, as a company, we are committed to make OpenStack better in Grid Dynamics. Please welcome our new employee and OpenStack developer - Nikolay Sokolov.

[Jay Pipes (jaypipes)]

Welcome to the community, Nikolay! :)

-jay

On Tue, Jul 5, 2011 at 2:45 PM, Andrey Brindeyev
<email address hidden> wrote:
> Brian, as a company, we are committed to make OpenStack better in Grid
> Dynamics. Please welcome our new employee and OpenStack developer -
> Nikolay Sokolov.
>
> --
> You received this bug notification because you are a member of Nova Bug
> Team, which is subscribed to OpenStack Compute (nova).
> https://bugs.launchpad.net/bugs/805604
>
> Title:
>  Multiprocess nova-api does not handles SIGTERM correctly.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/nova/+bug/805604/+subscriptions
>

[Nikolay Sokolov (chemikadze)]

I'm wating for review for two days. I thing that it is too long for 3-line pathch.