[windows] F1 shortcut does not work
Bug #805082 reported by
Andreas Preikschat
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Committed
|
Low
|
Azaziah | ||
Bug Description
Hey,
The F1 shortcut is assigned twice in build 1672. They "Help" and "Online Help" entries are affected (in the help menu). This is due to a change (1667).
Only old installations are affected (because the shortcut for the online help was saved and loaded, but the "help" entry shortcut was set to its default, which is F1 as well).
Solution:
- change the actions' object names (to reset the two shortcuts)
- Revert the shortcut changes from r1667
Related branches
lp:~googol-deactivatedaccount/openlp/bug-805082
- Raoul Snyman: Approve
- Tim Bentley: Approve
-
Diff: 132 lines (+27/-40)1 file modifiedopenlp/core/ui/mainwindow.py (+27/-40)
lp:~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc
- Tomas Groth: Approve
- Tim Bentley: Approve
-
Diff: 438 lines (+89/-102)12 files modifiedopenlp/core/common/settings.py (+6/-4)
openlp/core/ui/exceptiondialog.py (+1/-1)
openlp/core/ui/exceptionform.py (+1/-1)
openlp/core/ui/mainwindow.py (+16/-32)
openlp/core/ui/shortcutlistform.py (+3/-3)
openlp/core/ui/slidecontroller.py (+35/-30)
openlp/plugins/custom/lib/mediaitem.py (+1/-1)
openlp/plugins/songs/forms/editsongform.py (+1/-1)
resources/images/openlp-2.qrc (+0/-1)
tests/functional/openlp_core_ui/test_slidecontroller.py (+2/-25)
tests/functional/openlp_plugins/bibles/test_mediaitem.py (+21/-0)
tests/functional/openlp_plugins/bibles/test_swordimport.py (+2/-3)
| Changed in openlp: | |
| milestone: | none → 1.9.7 |
Revision history for this message
| Andreas Preikschat (googol-deactivatedaccount) wrote | #1 |
| Changed in openlp: | |
| status: | New → Triaged |
| Changed in openlp: | |
| assignee: | nobody → Andreas Preikschat (googol) |
| status: | Triaged → In Progress |
| Changed in openlp: | |
| importance: | Undecided → Low |
| status: | In Progress → Fix Committed |
| Changed in openlp: | |
| status: | Fix Committed → Fix Released |
| Changed in openlp: | |
| assignee: | Andreas Preikschat (googol) → Azaziah (suutari-olli) |
| Changed in openlp: | |
| status: | Fix Released → In Progress |
| Changed in openlp: | |
| status: | In Progress → Fix Committed |
| milestone: | 1.9.7 → 2.5.1 |
To post a comment you must log in.
The (best) solution would possible be to change the object names (and also the instances themselves) to something like onlineHelp/