Bug #804791 “D-Link DSL-2640B Router doesn't work with upnp-rout...” : Bugs : UPnP Router Control

Revision history for this message

Giorgio Vazzana (mywing) wrote on 2011-07-02:

#1

Patch for D-Link DSL-2640B Router Edit (585 bytes, text/plain)

Revision history for this message

Giorgio Vazzana (mywing) wrote on 2011-07-02:

#2

Screenshot of UPnP Devices/Services on my router Edit (203.0 KiB, image/png)

Revision history for this message

Daniele Napolitano (dnax88) wrote on 2011-08-23:

#3

fix-for-bug804791.patch Edit (640 bytes, text/plain)

Hi, thanks for this bug report. Can you try my patch? Is very similar to yours but I do a further check.

Changed in upnp-router-control:
status:	New → Confirmed
importance:	Undecided → Medium

Revision history for this message

Giorgio Vazzana (mywing) wrote on 2011-08-24:

#4

urc-bzr2.diff Edit (628 bytes, text/plain)

Hello Daniele,

thanks for looking into this issue. I tried your patch but it doesn't solve the problem, it still fails to recognize my router:

holden@rye:~/src/upnp-router-control$ upnp-router-control --debug
* Initializing GUI...
* Showing GUI...
* Starting UPnP Resource discovery... done
==> Device Available: D-Link DSL-2640B
   Model description: Broadcom single-chip ADSL router
          Model name: BRCM963xx
        Model number: 1.0
               Brand: Broadcom
    Presentation URL: http://192.168.1.1/
                 UPC: (null)
  Unique Device Name: uuid:0000e0b8-20a0-00e0-c0a0-4818000808e0
    Enum services...
      Service: urn:upnp-org:serviceId:Layer3Forwarding:11
         Type: urn:schemas-upnp-org:service:Layer3Forwarding:1
               > GetDefaultConnectionService
               > SetDefaultConnectionService
      ** Getting DefaultConnectionService...
[WW] GetDefaultConnectionService: empty
    Enum sub-devices...
      Sub-Device: urn:schemas-upnp-org:device:WANDevice:1
        Enum services...
          Service: urn:upnp-org:serviceId:WANCommonIFC1
             Type: urn:schemas-upnp-org:service:WANCommonInterfaceConfig:1
                   > GetCommonLinkProperties
                   > GetTotalBytesSent
                   > GetTotalBytesReceived
                   > GetTotalPacketsReceived
                   > GetTotalPacketsSent
Request for WAN link properties... successful
WAN link properties: access_type=DSL, link_status=Up, max_up=284000, max_down=2253000
        Enum sub-devices...
          Sub-Device: urn:schemas-upnp-org:device:WANConnectionDevice:1
            Enum services...
              Service: urn:upnp-org:serviceId:WANPPPConn1
                 Type: urn:schemas-upnp-org:service:WANPPPConnection:1
                       > SetConnectionType
                       > GetConnectionTypeInfo
                       > GetStatusInfo
                       > GetNATRSIPStatus
                       > GetGenericPortMappingEntry
                       > GetSpecificPortMappingEntry
                       > AddPortMapping
                       > DeletePortMapping
                       > GetExternalIPAddress
GetTotalBytesReceived() duration: 1,005439s
GetTotalBytesSent() duration: 1,044330s
GetTotalBytesReceived() duration: 1,003763s
GetTotalBytesSent() duration: 1,034698s
GetTotalBytesReceived() duration: 1,003708s
GetTotalBytesSent() duration: 1,035517s
* Destroying GUI...

I gave a quick look at the code, and from what I can see in urc-upnp.c if string_buffer=="" in get_default_connection_service() (line 558) then connect_service is set to NULL (line 577), so connect_service in device_proxy_available_cb() can never be an empty string. The attached patch works ok, was it this what you had in mind?

Hello Daniele,

thanks for looking into this issue. I tried your patch but it doesn't solve the problem, it still fails to recognize my router:

holden@rye:~/src/upnp-router-control$ upnp-router-control --debug
* Initializing GUI...
* Showing GUI...
* Starting UPnP Resource discovery... done
==> Device Available: D-Link DSL-2640B
   Model description: Broadcom single-chip ADSL router
          Model name: BRCM963xx
        Model number: 1.0
               Brand: Broadcom
    Presentation URL: http://192.168.1.1/
                 UPC: (null)
  Unique Device Name: uuid:0000e0b8-20a0-00e0-c0a0-4818000808e0
    Enum services...
      Service: urn:upnp-org:serviceId:Layer3Forwarding:11
         Type: urn:schemas-upnp-org:service:Layer3Forwarding:1
               > GetDefaultConnectionService
               > SetDefaultConnectionService
      ** Getting DefaultConnectionService...
[WW] GetDefaultConnectionService: empty
    Enum sub-devices...
      Sub-Device: urn:schemas-upnp-org:device:WANDevice:1
        Enum services...
          Service: urn:upnp-org:serviceId:WANCommonIFC1
             Type: urn:schemas-upnp-org:service:WANCommonInterfaceConfig:1
                   > GetCommonLinkProperties
                   > GetTotalBytesSent
                   > GetTotalBytesReceived
                   > GetTotalPacketsReceived
                   > GetTotalPacketsSent
Request for WAN link properties... successful
WAN link properties: access_type=DSL, link_status=Up, max_up=284000, max_down=2253000
        Enum sub-devices...
          Sub-Device: urn:schemas-upnp-org:device:WANConnectionDevice:1
            Enum services...
              Service: urn:upnp-org:serviceId:WANPPPConn1
                 Type: urn:schemas-upnp-org:service:WANPPPConnection:1
                       > SetConnectionType
                       > GetConnectionTypeInfo
                       > GetStatusInfo
                       > GetNATRSIPStatus
                       > GetGenericPortMappingEntry
                       > GetSpecificPortMappingEntry
                       > AddPortMapping
                       > DeletePortMapping
                       > GetExternalIPAddress
GetTotalBytesReceived() duration: 1,005439s
GetTotalBytesSent() duration:     1,044330s
GetTotalBytesReceived() duration: 1,003763s
GetTotalBytesSent() duration:     1,034698s
GetTotalBytesReceived() duration: 1,003708s
GetTotalBytesSent() duration:     1,035517s
* Destroying GUI...

I gave a quick look at the code, and from what I can see in urc-upnp.c if string_buffer=="" in get_default_connection_service() (line 558) then connect_service is set to NULL (line 577), so connect_service in device_proxy_available_cb() can never be an empty string. The attached patch works ok, was it this what you had in mind?

Revision history for this message

Bernardo Donadio (bcdonadio) wrote on 2012-06-18:

#5

strace on dsl-2730b Edit (295.9 KiB, text/plain)

I also confirms that this affects also DSL-2730B, which is from the same family.

Here's the (useless) stdout:
sorinan@hitchens:~/upnp-router-control$ upnp-router-control --debug
* Initializing GUI...
* Showing GUI...
* Starting UPnP Resource discovery... done
* Destroying GUI...

Attached is the strace.

Revision history for this message

Bernardo Donadio (bcdonadio) wrote on 2012-06-18:

#6

Download full text (4.7 KiB)

Here's the packet that is sent back to my computer when upnp-router-control query the network:

No. Time Source Destination Protocol Length Info
10710 775.680644 192.168.1.1 192.168.1.103 SSDP 305 HTTP/1.1 200 OK

Frame 10710: 305 bytes on wire (2440 bits), 305 bytes captured (2440 bits)
    Arrival Time: Jun 17, 2012 22:51:32.061794000 BRT
    Epoch Time: 1339984292.061794000 seconds
    [Time delta from previous captured frame: 0.000707000 seconds]
    [Time delta from previous displayed frame: 0.500752000 seconds]
    [Time since reference or first frame: 775.680644000 seconds]
    Frame Number: 10710
    Frame Length: 305 bytes (2440 bits)
    Capture Length: 305 bytes (2440 bits)
    [Frame is marked: False]
    [Frame is ignored: False]
    [Protocols in frame: eth:ip:udp:http]
    [Coloring Rule Name: HTTP]
    [Coloring Rule String: http || tcp.port == 80]
Ethernet II, Src: D-LinkIn_93:6b:d8 (28:10:7b:93:6b:d8), Dst: Azurewav_a9:75:79 (74:2f:68:a9:75:79)
    Destination: Azurewav_a9:75:79 (74:2f:68:a9:75:79)
        Address: Azurewav_a9:75:79 (74:2f:68:a9:75:79)
        .... ...0 .... .... .... .... = IG bit: Individual address (unicast)
        .... ..0. .... .... .... .... = LG bit: Globally unique address (factory default)
    Source: D-LinkIn_93:6b:d8 (28:10:7b:93:6b:d8)
        Address: D-LinkIn_93:6b:d8 (28:10:7b:93:6b:d8)
        .... ...0 .... .... .... .... = IG bit: Individual address (unicast)
        .... ..0. .... .... .... .... = LG bit: Globally unique address (factory default)
    Type: IP (0x0800)
Internet Protocol Version 4, Src: 192.168.1.1 (192.168.1.1), Dst: 192.168.1.103 (192.168.1.103)
    Version: 4
    Header length: 20 bytes
    Differentiated Services Field: 0x00 (DSCP 0x00: Default; ECN: 0x00: Not-ECT (Not ECN-Capable Transport))
        0000 00.. = Differentiated Services Codepoint: Default (0x00)
        .... ..00 = Explicit Congestion Notification: Not-ECT (Not ECN-Capable Transport) (0x00)
    Total Length: 291
    Identification: 0x0000 (0)
    Flags: 0x02 (Don't Fragment)
        0... .... = Reserved bit: Not set
        .1.. .... = Don't fragment: Set
        ..0. .... = More fragments: Not set
    Fragment offset: 0
    Time to live: 64
    Protocol: UDP (17)
    Header checksum: 0xb611 [correct]
        [Good: True]
        [Bad: False]
    Source: 192.168.1.1 (192.168.1.1)
    Destination: 192.168.1.103 (192.168.1.103)
User Datagram Protocol, Src Port: ssdp (1900), Dst Port: 35074 (35074)
    Source port: ssdp (1900)
    Destination port: 35074 (35074)
    Length: 271
    Checksum: 0xc880 [validation disabled]
        [Good Checksum: False]
        [Bad Checksum: False]
Hypertext Transfer Protocol
    HTTP/1.1 200 OK\r\n
        [Expert Info (Chat/Sequence): HTTP/1.1 200 OK\r\n]
            [Message: HTTP/1.1 200 OK\r\n]
            [Severity level: Chat]
            [Group: Sequence]
        Request Version: HTTP/1.1
        Status Code: 200
        Response Phrase: OK
    Server: Custom/1.0 UPnP/1.0 Proc/Ver\r\n
    EXT:\r\n
    Location: http://192.168.1.1:5431/dyndev/uuid:28107b93-6bd8-d86b-937b-10281093d80000\r\n
    Cache-Contr...

Here's the packet that is sent back to my computer when upnp-router-control query the network:

No.     Time        Source                Destination           Protocol Length Info
  10710 775.680644  192.168.1.1           192.168.1.103         SSDP     305    HTTP/1.1 200 OK

Frame 10710: 305 bytes on wire (2440 bits), 305 bytes captured (2440 bits)
    Arrival Time: Jun 17, 2012 22:51:32.061794000 BRT
    Epoch Time: 1339984292.061794000 seconds
    [Time delta from previous captured frame: 0.000707000 seconds]
    [Time delta from previous displayed frame: 0.500752000 seconds]
    [Time since reference or first frame: 775.680644000 seconds]
    Frame Number: 10710
    Frame Length: 305 bytes (2440 bits)
    Capture Length: 305 bytes (2440 bits)
    [Frame is marked: False]
    [Frame is ignored: False]
    [Protocols in frame: eth:ip:udp:http]
    [Coloring Rule Name: HTTP]
    [Coloring Rule String: http || tcp.port == 80]
Ethernet II, Src: D-LinkIn_93:6b:d8 (28:10:7b:93:6b:d8), Dst: Azurewav_a9:75:79 (74:2f:68:a9:75:79)
    Destination: Azurewav_a9:75:79 (74:2f:68:a9:75:79)
        Address: Azurewav_a9:75:79 (74:2f:68:a9:75:79)
        .... ...0 .... .... .... .... = IG bit: Individual address (unicast)
        .... ..0. .... .... .... .... = LG bit: Globally unique address (factory default)
    Source: D-LinkIn_93:6b:d8 (28:10:7b:93:6b:d8)
        Address: D-LinkIn_93:6b:d8 (28:10:7b:93:6b:d8)
        .... ...0 .... .... .... .... = IG bit: Individual address (unicast)
        .... ..0. .... .... .... .... = LG bit: Globally unique address (factory default)
    Type: IP (0x0800)
Internet Protocol Version 4, Src: 192.168.1.1 (192.168.1.1), Dst: 192.168.1.103 (192.168.1.103)
    Version: 4
    Header length: 20 bytes
    Differentiated Services Field: 0x00 (DSCP 0x00: Default; ECN: 0x00: Not-ECT (Not ECN-Capable Transport))
        0000 00.. = Differentiated Services Codepoint: Default (0x00)
        .... ..00 = Explicit Congestion Notification: Not-ECT (Not ECN-Capable Transport) (0x00)
    Total Length: 291
    Identification: 0x0000 (0)
    Flags: 0x02 (Don't Fragment)
        0... .... = Reserved bit: Not set
        .1.. .... = Don't fragment: Set
        ..0. .... = More fragments: Not set
    Fragment offset: 0
    Time to live: 64
    Protocol: UDP (17)
    Header checksum: 0xb611 [correct]
        [Good: True]
        [Bad: False]
    Source: 192.168.1.1 (192.168.1.1)
    Destination: 192.168.1.103 (192.168.1.103)
User Datagram Protocol, Src Port: ssdp (1900), Dst Port: 35074 (35074)
    Source port: ssdp (1900)
    Destination port: 35074 (35074)
    Length: 271
    Checksum: 0xc880 [validation disabled]
        [Good Checksum: False]
        [Bad Checksum: False]
Hypertext Transfer Protocol
    HTTP/1.1 200 OK\r\n
        [Expert Info (Chat/Sequence): HTTP/1.1 200 OK\r\n]
            [Message: HTTP/1.1 200 OK\r\n]
            [Severity level: Chat]
            [Group: Sequence]
        Request Version: HTTP/1.1
        Status Code: 200
        Response Phrase: OK
    Server: Custom/1.0 UPnP/1.0 Proc/Ver\r\n
    EXT:\r\n
    Location: http://192.168.1.1:5431/dyndev/uuid:28107b93-6bd8-d86b-937b-10281093d80000\r\n
    Cache-Control:max-age=1800\r\n
    ST:upnp:rootdevice\r\n
    USN:uuid:28107b93-6bd8-d86b-937b-10281093d80000::upnp:rootdevice\r\n
    \r\n

0000  74 2f 68 a9 75 79 28 10 7b 93 6b d8 08 00 45 00   t/h.uy(.{.k...E.
0010  01 23 00 00 40 00 40 11 b6 11 c0 a8 01 01 c0 a8   .#..@.@.........
0020  01 67 07 6c 89 02 01 0f c8 80 48 54 54 50 2f 31   .g.l......HTTP/1
0030  2e 31 20 32 30 30 20 4f 4b 0d 0a 53 65 72 76 65   .1 200 OK..Serve
0040  72 3a 20 43 75 73 74 6f 6d 2f 31 2e 30 20 55 50   r: Custom/1.0 UP
0050  6e 50 2f 31 2e 30 20 50 72 6f 63 2f 56 65 72 0d   nP/1.0 Proc/Ver.
0060  0a 45 58 54 3a 0d 0a 4c 6f 63 61 74 69 6f 6e 3a   .EXT:..Location:
0070  20 68 74 74 70 3a 2f 2f 31 39 32 2e 31 36 38 2e    http://192.168.
0080  31 2e 31 3a 35 34 33 31 2f 64 79 6e 64 65 76 2f   1.1:5431/dyndev/
0090  75 75 69 64 3a 32 38 31 30 37 62 39 33 2d 36 62   uuid:28107b93-6b
00a0  64 38 2d 64 38 36 62 2d 39 33 37 62 2d 31 30 32   d8-d86b-937b-102
00b0  38 31 30 39 33 64 38 30 30 30 30 0d 0a 43 61 63   81093d80000..Cac
00c0  68 65 2d 43 6f 6e 74 72 6f 6c 3a 6d 61 78 2d 61   he-Control:max-a
00d0  67 65 3d 31 38 30 30 0d 0a 53 54 3a 75 70 6e 70   ge=1800..ST:upnp
00e0  3a 72 6f 6f 74 64 65 76 69 63 65 0d 0a 55 53 4e   :rootdevice..USN
00f0  3a 75 75 69 64 3a 32 38 31 30 37 62 39 33 2d 36   :uuid:28107b93-6
0100  62 64 38 2d 64 38 36 62 2d 39 33 37 62 2d 31 30   bd8-d86b-937b-10
0110  32 38 31 30 39 33 64 38 30 30 30 30 3a 3a 75 70   281093d80000::up
0120  6e 70 3a 72 6f 6f 74 64 65 76 69 63 65 0d 0a 0d   np:rootdevice...
0130  0a                                                .

Daniele Napolitano (dnax88) on 2023-06-05

Changed in upnp-router-control:
status:	Confirmed → Fix Committed

Daniele Napolitano (dnax88) on 2023-08-03

Changed in upnp-router-control:
status:	Fix Committed → Fix Released
milestone:	none → 0.3.2

UPnP Router Control

D-Link DSL-2640B Router doesn't work with upnp-router-control

Bug Description

Other bug subscribers

Patches

Bug attachments

Remote bug watches