Open Terminal doesn't use default DE app

Bug #804459 reported by Sergey "Shnatsel" Davidoff
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Marlin
Won't Fix
Wishlist
Unassigned

Bug Description

Open Terminal extension should call /usr/bin/x-terminal-emulator instead of gnome-terminal.
Especially useful since we will have a custom terminal emulator.

Tags: bitesize
tags: added: bitesize
Revision history for this message
xapantu (xapantu) wrote : Re: [Bug 804459] [NEW] Open Terminal hardcodes terminal command

 status triaged
 importance wishlist

If I recall correctly, there is already a dconf key for that, it is not
hardcoded. But we could change the default…

Le vendredi 01 juillet 2011 à 18:20 +0000, Sergey "Shnatsel" Davidoff a
écrit :
> Public bug reported:
>
> Open Terminal extension should call /usr/bin/x-terminal-emulator instead of gnome-terminal.
> Especially useful since we will have a custom terminal emulator.
>
> ** Affects: marlin
> Importance: Undecided
> Status: New
>
>
> ** Tags: bitesize
>
> ** Tags added: bitesize
>

Changed in marlin:
importance: Undecided → Wishlist
status: New → Triaged
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote : Re: Open Terminal hardcodes terminal command

I've set both the Debian alternatives system (/usr/share/x-terminal-emulator) and the dconf keys (exec and exec-arg in [org.gnome.desktop.default-applications.terminal] schema) pointing to pantheon-terminal, and Marlin still opens gnome-terminal.

Revision history for this message
xapantu (xapantu) wrote : Re: [Bug 804459] Re: Open Terminal hardcodes terminal command

You must change the plugin key, something like
apps.marlin.plugins.openterminal.default-terminal.

Le samedi 09 juillet 2011 à 17:27 +0000, Sergey "Shnatsel" Davidoff a
écrit :
> I've set both the Debian alternatives system (/usr/share/x-terminal-
> emulator) and the dconf keys (exec and exec-arg in [org.gnome.desktop
> .default-applications.terminal] schema) pointing to pantheon-terminal,
> and Marlin still opens gnome-terminal.
>

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

xapantu: it it better with the new description?
IMHO it should use data from [org.gnome.desktop.default-applications.terminal] because GSettings is a GNOME API anyway and we're bound to GNOME in these parts anyway. If it doesn't exist (Marlin used in XFCE or something), fall back to /usr/share/x-terminal-emulator. This should be the most portable solution honoring DE application defaults at the same time.

summary: - Open Terminal hardcodes terminal command
+ Open Terminal doesn't use default DE app
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

I also think that using --current-directory parameter is not portable. However, both gnome-terminal and pantheon-terminal use the working directory from which they were launched as their default working directory, and I think other terminal emulators do the same.

Revision history for this message
xapantu (xapantu) wrote : Re: [Bug 804459] Re: Open Terminal doesn't use default DE app

GSettings is not a gnome api, it is a part of gio (which is a part of
glib). Regarding x-terminal-emulator, ok, it could be the default one.

For org.gnome.desktop.default-applications.terminal, I don't have this
key, and it is better to use freedesktop standard, so, we'll use
x-terminal-emulator.

Le samedi 09 juillet 2011 à 17:58 +0000, Sergey "Shnatsel" Davidoff a
écrit :
> xapantu: it it better with the new description?
> IMHO it should use data from [org.gnome.desktop.default-applications.terminal] because GSettings is a GNOME API anyway and we're bound to GNOME in these parts anyway. If it doesn't exist (Marlin used in XFCE or something), fall back to /usr/share/x-terminal-emulator. This should be the most portable solution honoring DE application defaults at the same time.
>
> ** Summary changed:
>
> - Open Terminal hardcodes terminal command
> + Open Terminal doesn't use default DE app
>

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

You don't have this key because Natty doesn't have it, it's present only in GNOME3 which is not integrated in Natty. It's already present on Oneiric.

Also, I doubt that /usr/bin/x-terminal-emulator is a freedesktop standard because on Debian/Ubuntu it depends on Debian-specific alternatives system.

Revision history for this message
xapantu (xapantu) wrote :

I meant a Xorg.

Le dimanche 10 juillet 2011 à 10:43 +0000, Sergey "Shnatsel" Davidoff a
écrit :
> You don't have this key because Natty doesn't have it, it's present only
> in GNOME3 which is not integrated in Natty. It's already present on
> Oneiric.
>
> Also, I doubt that /usr/bin/x-terminal-emulator is a freedesktop
> standard because on Debian/Ubuntu it depends on Debian-specific
> alternatives system.
>

Revision history for this message
Allen Lowe (lallenlowe) wrote :

so what have we decided on then?

Revision history for this message
xapantu (xapantu) wrote :

We should just use x-terminal-emulator by default, and modify the
g_spawn call to start it in the good directory.

Le lundi 11 juillet 2011 à 18:10 +0000, Allen Lowe a écrit :
> so what have we decided on then?
>

Revision history for this message
xapantu (xapantu) wrote :

Now useless since he won't be maintained, it will be replaced by contracts from terminals apps.

Changed in marlin:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.