Files are not written as binary

[Roberto Alsina]

When syncing a file created on Linux to Windows, the EOLs are being converted. This corrupts every non-text file.

Here is the example file created on Linux (14 bytes):

>>> print repr(open('test.txt','rb').read())
'Line 1\nLine 2\n'

And here is the same file after it's synced to windows:

>>> print repr(open('test.txt','rb').read())
'Line 1\r\nLine 2\r\n'

Probably a ' b' flag missing in some open call.

[Manuel de la Peña (mandel)]

Is more probable that some code is not using the os_helper.open_file method which adds the 'b' in the mode if not present. Lets hope that grep can return the exact places for this.

[Manuel de la Peña (mandel)]

I correct myself, it looks like in one of our reverts we lost the appending of the 'b' in the open_file from os_helper on windows, this should be a straight fix then :)