$SOCKETDIR variable usage in byobu scripts

Bug #802122 reported by zorun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu
Fix Released
High
Dustin Kirkland 
byobu (Ubuntu)
Fix Released
High
Dustin Kirkland 

Bug Description

How do byobu scripts get called? Are there some variables defined, such as $SOCKETDIR?

My point is that a small part of the code (namely, "/usr/bin/byobu{,-select-profile,janitor}") is using the following to set SOCKETDIR:
    [ -r "/etc/$PKG/socketdir" ] && . "/etc/$PKG/socketdir" || SOCKETDIR="/var/run/screen"

Which is perfect for portability, as a distro might want to put screen sessions in /tmp.

However, every script (in /usr/lib/byobu/) I check is making use of the hardcoded /var/run/screen path... Is this intended? Or a missing feature? Or is there anything preventing one from using a variable? (hence my initial question)

Thanks

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Thanks for the report and the branch.

I've committed a positvely massive changeset to address this. Please do help test it, and leave your feedback here or in new bugs.

Cheers!

Changed in byobu:
status: New → Fix Committed
importance: Undecided → High
assignee: nobody → Dustin Kirkland (kirkland)
Changed in ubuntu:
status: New → Fix Committed
importance: Undecided → High
assignee: nobody → Dustin Kirkland (kirkland)
Changed in byobu:
status: Fix Committed → Fix Released
affects: ubuntu → byobu (Ubuntu)
Changed in byobu (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.