Zope readline call fails in Edgy

[Tom Hoffman]

When you add a person, you get this:

2006-11-09 10:44:28,057 http://localhost:7080
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/zope/publisher/publish.py", line 131,
in publish
    request.processInputs()
  File "/usr/lib/python2.4/site-packages/zope/publisher/browser.py", line 255,
in processInputs
    fs = FieldStorage(fp=fp, environ=self._environ, keep_blank_values=1)
  File "cgi.py", line 530, in __init__
    self.read_multi(environ, keep_blank_values, strict_parsing)
  File "cgi.py", line 650, in read_multi
    environ, keep_blank_values, strict_parsing)
  File "cgi.py", line 532, in __init__
    self.read_single()
  File "cgi.py", line 665, in read_single
    self.read_lines()
  File "cgi.py", line 687, in read_lines
    self.read_lines_to_outerboundary()
  File "cgi.py", line 715, in read_lines_to_outerboundary
    line = self.fp.readline(1<<16)
TypeError: readline() takes exactly 1 argument (2 given)

[Brian Sutherland (jinty)]

Looks like this:
    http://www.zope.org/Collectors/Zope3-dev/535

The ubuntu packagers need to add this patch to their zope3 package:
http://lists.alioth.debian.org/pipermail/pkg-zope-commits/2006-October/000342.html

Almost certainly this is not a schooltool issue.

[William Grant (wgrant)]

This isn't a bug in SchoolTool. I've added a task for zope3 in Ubuntu.

[William Grant (wgrant)]

This breaks a fair bit of Zope 3 functionality. Adding most new items through the ZMI triggers this error, for example, making it somewhat unusable. SchoolTool also doesn't work. One would assume it breaks others as well.

This is a regression from Dapper, as it is caused by a change in Python 2.4.4. It is fixed in Feisty, as a similar fix (but for Zope 3.3) was committed to Debian (as shown above) and then synced into Feisty.

Thus, I request that this be considered for a stable release update. I've attached a debdiff which I have tested on a number of Edgy machines. The patch is taken directly from an upstream commit, and has little or no potential for regressions.

[Martin Pitt (pitti)]

Patch looks fine and reasoning is convincing. Please go ahead and upload.

[Martin Pitt (pitti)]

Except that (a) you cannot upload this (it's in main), and (b) I forgot to mention that the changelog should be written in a more verbose and user-oriented way. Please explain the impact and what the patch does. Please attach a new debdiff, I'll sponsor the upload for you.

[Martin Pitt (pitti)]

Please set back to 'in progress' when you attach a new debdiff.

[William Grant (wgrant)]

New debdiff attached. Thanks for offering to sponsor.

[Martin Pitt (pitti)]

Sponsored and accepted into edgy-proposed. Please go ahead with QA testing.

[Michael Vogt (mvo)]

Thanks for your update.

Please include instructions how to reproduce the bug. The policy says:
"Detailled instructions how to reproduce the bug.- These should allow someone who is not familiar with the affected package to reproduce the bug and verify that the updated package fixes the problem."

I will be happy to do the verification once I have this instructions.

Thanks,
 Michael

[Martin Pitt (pitti)]

Nobody tested the -proposed upload and gave feedback here for more than half a year, and I guess nobody cares about edgy desktop any more, so I removed the -proposed package.