Crash when pressing Ctrl+L when two windows are open

[Timo Reimerdes]

Marlin: 0.1-0~384~oneiric1
Operating system: Ubuntu oneiric (June 23rd, 2011)
Kernel: 3.0-1-generic

Reproduce (happens every time):
1) Run marlin
2) Open a second marlin window (Ctrl+N)
3) Press Ctrl+L for location bar input

Result:
Crash with memory error and the following commandline message:
[FATAL 12:35:53.744242] [Gtk] gtk_container_get_focus_child: assertion `GTK_IS_CONTAINER (container)' failed
[FATAL 12:35:53.744260] marlin will not function properly.

Expected:
The focused marlin window should prompt for input in the location path bar.

[Sergey "Shnatsel" Davidoff (shnatsel)]

I can confirm the segfault with the test case described above.

[Robert Roth (evfool)]

I think the same issue can be seen by simply pressing Ctrl+L twice, no need to open two windows, but we'll know that for sure when one of the issues will be fixed.

[Timo Reimerdes (timorei)]

I'd think those might be related, but not the same:

In one case an inputfield-focus is supposed to be given, but it's target doesn't get decided.

In the other case there seems to be a problem with closing the input field and what happens next. What happened to the pathbar when the input field replaced it?

[Robert Roth (evfool)]

Vadim's fix works, fixes both crashes, the app does not crash now in neither one of the cases, but I feel like Ctrl+L should toggle the location bar and the breadcrumbs, so double-Ctrl+L should show the breadcrumbs.

[xapantu (xapantu)]

In fact, the long term idea would be to remove this Entry, but we wait
for the pathbar to be ready (there are still some issues with the
selection). So, maybe it would be better, I don't know, but it would be
surprising, ATM, the breacrumbs can't have the focus, so, it would be
very weird...

[Timo Reimerdes (timorei)]

Confirming the bug to not happen anymore.

An esc should cancel the entry-mode and return the focus to the last owner - or just always the folder view pane, imho.

Right now the only ways to get out of it is clicking or enter. There is no way to "cancel" as far as I can see?

[Saddy (sadmail)]

I used to use Ctrl+L to copy the current directory path in another terminal (and cd to it). It's not possible anymore. Is this going to work again in future versions?

[ammonkey (am-monkeyd)]

status fixreleased

[ammonkey (am-monkeyd)]

 status fixreleased

On 15 April 2013 15:33, am monkeyd <email address hidden> wrote:

> status fixreleased
>

[ammonkey (am-monkeyd)]

 status fixreleased