gather_details evaluates details

[Robert Collins]

This results in too-early evaluation when used in python-fixtures; what we need there is the conflict logic - evaluation can/should happen when a test case or something which is going to destroy the context wants to report on the details.

[Jonathan Lange (jml)]

Could you please break this down into expected; observed; how-to-repro?

[Robert Collins (lifeless)]

On Mon, Jul 4, 2011 at 10:27 PM, Jonathan Lange <email address hidden> wrote:
> Could you please break this down into expected; observed; how-to-repro?

Its probably easiest to look at what I landed in fixtures;gavin reused
gather_details, but it causes early-evaluation which is only desirable
once: at the very end of a test right before teardown.

[Jonathan Lange (jml)]

Am guessing this is http://bazaar.launchpad.net/+branch/python-fixtures/revision/27 and that the difference is that gather_details calls _copy_content on source content, which is what evaluates the details.

test_details_from_child_fixtures_are_returned from the aforementioned diff is probably a good starting point for reproducing the bug.

[Robert Collins (lifeless)]

See also combine_details()

[Jonathan Lange (jml)]

Wondering if this was fixed by https://code.launchpad.net/~jml/testtools/gather-details-dict-801027/+merge/68599.

[Jonathan Lange (jml)]

Marked as Incomplete because I think this bug is fixed but don't understand it well enough to mark it as such.

[Jonathan Lange (jml)]

This is Not A Bug, since python-fixtures *relies* on gather_details evaluating details. I've posted a patch that documents this behaviour: https://github.com/testing-cabal/testtools/pull/184