Odoo Addons (MOVED TO GITHUB)

Account Module : account.journal write method only accepts list ids

Bug #800693 reported by Guewen Baconnier @ Camptocamp
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 3
Odoo Addons (MOVED TO GITHUB) 6.1

Bug Description

Hi,

The method write of account_journal in addons/account/account.py iterates on ids without checking if this a list.
So we cannot do a write on a journal with its id in integer.

I attach the patches for 6.0 stable and trunk version.

Thanks

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-800693-bde
tfr (Openerp) (community): Needs Fixing
Mustufa Rangwala (Open ERP) (community): Approve
qdp (OpenERP): Pending requested
Diff: 12 lines (+2/-0)
1 file modified
account/account.py (+2/-0)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :
Revision history for this message
Amit Parik (amit-parik) wrote :

Hello,

The problem is occurs only when you have call the write method via script and passed the integer value in ids not the list.

And I have checked the attached patch and it is working fine.

I have attached a script which have run the write method and when you run this script you have faced the problem.

So I am confirming this issue.

Thanks.

Revision history for this message
Amit Parik (amit-parik) wrote :
Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Low
status: New → Confirmed
Bharat Devnani (Open ERP) (bde-openerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Bharat Devnani (Open ERP) (bde-openerp)
Changed in openobject-addons:
status: In Progress → Fix Committed
Mustufa Rangwala (Open ERP) (mra-tinyerp)
Changed in openobject-addons:
milestone: none → 6.1
Revision history for this message
Bharat Devnani (Open ERP) (bde-openerp) wrote :

Hello Guewen Baconnier,

The Revision ID and Revision Number of this bug is as follows :

Revision ID : bde@tiny2-desktop-20110630103918-lw61ms8hxs7ypkc3
Revision Number : 4834

Thanks for your patch, i have checked your its working fine, it will be merged in addons soon.

Regards,
Devnani Bharat R.

Fabien (Open ERP) (fp-tinyerp)
Changed in openobject-addons:
status: Fix Committed → Fix Released
Revision history for this message
qdp (OpenERP) (qdp) wrote :

fixed in revision 5072

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.