form-picker-macros should not do a bunch of manual js assembly
Bug #799847 reported by
j.c.sackett
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
j.c.sackett | ||
Bug Description
A large portion of picker configuration and setup is done in form-picker-macros. While we want the final setup done in this file so that all the necessary widgets are wired up together right, we shouldn't have so much of the configuration assembled in the page template and passed in from the view. Instead we should use the JSONCache
Additionally, we shouldn't repeat as much of the javascript as we do; much of the make_picker code could be part of an actual javascript file.
Related branches
lp:~jcsackett/launchpad/form-macros-frighten-me
- Benji York (community): Approve (code)
-
Diff: 175 lines (+25/-43)7 files modifiedlib/lp/answers/browser/tests/test_questiontarget.py (+2/-3)
lib/lp/app/javascript/picker/tests/test_picker_patcher.js (+3/-1)
lib/lp/app/widgets/popup.py (+7/-5)
lib/lp/app/widgets/templates/form-picker-macros.pt (+3/-13)
lib/lp/app/widgets/tests/test_popup.py (+6/-15)
lib/lp/blueprints/browser/tests/test_specificationtarget.py (+2/-3)
lib/lp/bugs/browser/tests/test_bugs.py (+2/-3)
lp:~jcsackett/launchpad/form-picker-macros-also-irritate-me
- Brad Crittenden (community): Approve (code)
-
Diff: 177 lines (+27/-43)7 files modifiedlib/lp/answers/browser/tests/test_questiontarget.py (+2/-3)
lib/lp/app/javascript/picker/tests/test_picker_patcher.js (+3/-1)
lib/lp/app/widgets/popup.py (+7/-5)
lib/lp/app/widgets/templates/form-picker-macros.pt (+5/-13)
lib/lp/app/widgets/tests/test_popup.py (+6/-15)
lib/lp/blueprints/browser/tests/test_specificationtarget.py (+2/-3)
lib/lp/bugs/browser/tests/test_bugs.py (+2/-3)
| Changed in launchpad: | |
| status: | Confirmed → Triaged |
| description: | updated |
| Changed in launchpad: | |
| assignee: | nobody → j.c.sackett (jcsackett) |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| William Grant (wgrant) wrote | #2 |
| tags: |
added: bad-commit-13485 qa-bad removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: |
added: qa-needstesting removed: qa-bad |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| tags: | added: disclosure |
To post a comment you must log in.
Fixed in stable r13485 <http://