Adding/deleting MFHD records is not synced throughout interface

[Dan Wells]

Adding or deleting MFHD records from the XUL menus requires coordinating the OPAC display, the XUL menus, and the Serial Control distribution editors. The current code frequently requires some non-obvious manual refreshing to make it work.

This branch keeps them in sync using custom events instead.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/mfhd_serctrl_sync

[Mike Rylander (mrylander)]

This looks fine to me, but I'd like someone with more staff-client-attuned eyes to look at it and try it out before I push it (if I indeed end up being the pusher).

[Dan Wells (dbw2)]

Here is a basic run through which can be used to test this branch. I have also pushed a number of fixes, so please pull again.

From a record with no MFHD or Serials data, do the following:
1. From the "Actions for this Record" menu, choose "Serial Control View"
2. Go to the Subscriptions tab
3. On the left sidebar, find your desired library location and right-click it; choose "Add Subscription"
4. Enter a valid date (YYYY-MM-DD) in the "Start Date" field, click "Apply", then click "Create Subscription(s)"
5. On the left sidebar under your subscription, right-click "Distributions" and choose "Add Distribution"
6. Click "Create Distribution(s)" (all fields are optional)
7. The Distributions Editor will disappear. Go back to your distribution so that it shows in the editor again. Note that the "Legacy Record Entry" dropdown has no MFHD Records.
8. On the "Actions for this Record" menu, choose the "MFHD Holdings" submenu, then "Add MFHD Record"; on the popup, choose the same Org Unit as your Distribution's Holding Lib, then click "Select"
9. On the Distributions Editor, click on "Legacy Record Entry" and notice that your new MFHD Record appears on the list.
10. On the "Actions for this Record" menu, choose the "MFHD Holdings" submenu, then choose the "Delete MFHD Record" submenu, then choose the MFHD Record; check the box to confirm and click "Delete"
11. On the Distributions Editor, click on "Legacy Record Entry" and notice that your deleted MFHD Record is gone from the list.

This doesn't actually result in a "working" setup, but that's beyond the scope of this bugfix.

Thanks Jason!

[Dan Wells (dbw2)]

Jason, I just realized at least one portion of this is not going to backport cleanly. I'll get a rel_2_0 branch pushed as soon as I can.

[Dan Wells (dbw2)]

First branch should pick cleanly into 2_1, new branch for 2_0 at user/dbwells/mfhd_serctrl_sync_rel_2_0

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/mfhd_serctrl_sync_rel_2_0

Thanks again.

[Jason Etheridge (phasefx)]

master:
http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=9970bcb407cd6eb399077084c0d79bd21496eef3
http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=13acc6a9e4bcd174384039b635dd9d76a51b781e

rel_2_1:
http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b2cddf129eab5415de06cd9a80ba25bb8ea6001e
http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2936369fc1cf99f6f29a4dbfbe994f27f7f5625b

rel_2_0:
http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=924294909633331f4dec3ee8cd4011c9458baf13
http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b1d1e4bb08a9966889e17b62a789c958b8cf298c

Thanks!