person picker allows deactivated users to be chosen

[Diogo Matsubara]

Searching in the person picker for a deactivated person will return that person in the results. If you try to save the changes, you get a 'Constraints not satisfied' error and a combo box with the deactivated user as a suggestion. See screenshot.

[William Grant (wgrant)]

How did you deactivate the person? Using +reviewaccount? Real deactivated people have no preferredemail, so won't show up in the picker.

[Curtis Hovey (sinzui)]

https://qastaging.launchpad.net/~dm-lptest-deactivatedaccount is not deactivated.
1. We can see it
2. It has an email address

I think the test may have be constructed poorly. Users cannot deactivate accounts via
https://qastaging.launchpad.net/~dm-lptest-deactivatedaccount/+reviewaccount
but ~registry members can. The deactivatation process removes the email address,
but direct manipulation of the account leaves the profile in a mixed state...that is
why ~registry admins NEVER deactivate user accounts. Users must do the deactivation
themselves

Suspension via +reviewaccount does the right thing and I have tested that suspended
users are not in the listing.