Today should be highlighted in weekly/monthly/yearly views

Bug #79865 reported by Marius Gedminas
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
SchoolTool
Fix Released
High
Justas Sadzevičius

Bug Description

We should highlight today in weekly/monthly/yearly calendar views, by making it
bold, adding a thicker border, or colouring the background differently.

Tags: calendar html
Revision history for this message
Brian Skahan (bskahan-deactivatedaccount) wrote :

r3207 adds an isToday() method to CalendarDay that returns bool for setting
id/class on a day in tal. I added it to week/month views but didn't expose it
in CSS since I couldn't seem to make it pretty. To close the bug I need to
figure out why it doesn't work with renderRow for year view.

Revision history for this message
Marius Gedminas (mgedmin) wrote :

I renamed isToday to today and implemented today highlighting in renderRow (used
both in yearly view and in three monthly calendars in the sidebar).

CSS rules are still missing.

Revisions needed for this feature: 3207, 3222, 3223 + whatever revision adds CSS.

Revision history for this message
Gintautas Miliauskas (gintas) wrote :

This looks like a nice and easy quick job. Perhaps somebody from Etria is
willing to take a stab at CSS? You guys are better at design than I am.

Changed in schooltool:
assignee: nobody → eldafar
status: In Progress → Unconfirmed
tags: added: calendar
Revision history for this message
Gediminas Paulauskas (menesis) wrote :

It is very confusing that a calendar does not highlight Today.

Changed in schooltool:
importance: Wishlist → High
no longer affects: schooltool/trunk
Revision history for this message
Tom Hoffman (tom-hoffman) wrote :

Try to fix this when you have some slack time, Justas. You can probably do it quicker than anyone else at this point.

Changed in schooltool:
assignee: nobody → Justas Sadzevičius (justas-pov)
Changed in schooltool:
status: Triaged → Fix Committed
Changed in schooltool:
milestone: none → 2.2.4
Changed in schooltool:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.