user_roles handles invalid user badly

[Mark Gius]

in function nova/admin.py - user_roles the behavior when the user_id is missing from the dashboard user db but is present in nova.

When running a GET request, if the submitted user cannot be found in the dashboard the page but is present in nova renders succesfully, except that the username on the form is missing. The submitted user_id is still forwarded on to nova even if the dashboard user is not present.

On POST, the dashboard userid is not used unless the form fails to validate, in which case the same behavior as a GET is seen.

This bug may become irrelevant if/when unified auth (keystone) is integrated into nova and the dashboard.

Reproduction Steps:
=============

Configure the dashboard for a nova API.

Run =manage.py syncdb=

Provide credentials for an admin user when presented.

Delete local/dashboard_openstack.sqlite3

Run = manage.py syncdb= again.

Provide different username/email.

Load up admin/roles/USERNAME2/

Notice everything looks good.

Load admin/roles/USERNAME1/

Page loads but username is missing.

[Mark Gius (markgius)]

project_view in the admin views has a simliar issue

[Mark Gius (markgius)]

and project_user

[Devin Carlen (devcamcar)]

Keystone support fixed this.