move Firefox from Cleaner.py to CleanerML

Bug #797995 reported by Andrew Ziem
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
BleachBit
Fix Released
Medium
Andrew Ziem

Bug Description

do not hardcode the cleaner

Andrew Ziem (ahziem1)
Changed in bleachbit:
milestone: 1.0.0 → 1.1
Revision history for this message
Andrew Ziem (ahziem1) wrote :

git e7baa23: Expose Mozilla URL history (places.sqlite) cleaner to CleanerML

Changed in bleachbit:
status: Triaged → In Progress
Revision history for this message
Andrew Ziem (ahziem1) wrote :

Started in 1.1/1.2 but needs more work

Changed in bleachbit:
milestone: 1.2 → 1.4
Andrew Ziem (ahziem1)
Changed in bleachbit:
milestone: 1.4 → 2.0
Changed in bleachbit:
milestone: 2.0 → 1.12
Revision history for this message
Andrew Ziem (ahziem1) wrote :

Many of the Firefox rules apply to many base paths, which can also change when the profile directory changes, so the next step may be to extend CleanerML to support a "base path" variable which can be referenced in each ACTION element.

This would also simplify other cleaners, such as Google Chrome, which have almost redundant rules between Windows and Linux except for the base path.

Revision history for this message
ROCKNROLLKID (slinger1410-deactivatedaccount) wrote :

Can I just ask: what is the difference in having it at .py and having it at .ml? Is it really something that is necessarily needed to be done?

Revision history for this message
Andrew Ziem (ahziem1) wrote :

First, moving Firefox to CleanerML will make it easier to support Firefox-based web browsers.

Second, some enhancements to CleanerML itself will benefit other cleaners not related to Firefox.

Third, it would be consistent to have them all in CleanerML instead of Python---something I started doing long, long ago.

Revision history for this message
ROCKNROLLKID (slinger1410-deactivatedaccount) wrote :

Alright, then I will tag this as medium importance as it seems like something that should be done.

Changed in bleachbit:
importance: Undecided → Medium
Revision history for this message
Andrew Ziem (ahziem1) wrote :

I would like not to delay the release of the improvements already made for BleachBit version 1.12

Changed in bleachbit:
milestone: 1.12 → 1.14
Andrew Ziem (ahziem1)
Changed in bleachbit:
status: In Progress → Triaged
Andrew Ziem (ahziem1)
Changed in bleachbit:
milestone: 2.0 → 2.2
Andrew Ziem (ahziem1)
Changed in bleachbit:
status: Triaged → Fix Committed
Andrew Ziem (ahziem1)
Changed in bleachbit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.