Call GTK functions without gdk lock

Bug #797188 reported by Yehouda
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
AppMenu GTK+
Fix Released
Medium
Allison Karlitskaya
Ubuntu
Invalid
Undecided
Unassigned

Bug Description

There are calls to GTK functions without a gdk lock, which cause "random" crashes on mullti-threaded applications.

The one that we hit is the call to
  dsubmenu_gtk_parse_menu_structure
  find_menu_bar
  ...
  rebuild_window_items
  do_rebuild
  <glib stuff>

It is because is called vi g_timeout_add inside rebuild, which doesn't deal with gdk lock.
It should call gdk_threads_add_timeout instead.

We found the bug running on Linux Mint.

As a work around we setenv UBUNTU_MENUPROXY to nothing.
Other iseas?

Related branches

Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

From what it appears, this seems to be a bug with the ubuntumenuproxy part of Ubuntu's patched GTK source.

Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

On a side note, does this issue occur with Oneiric (GTK 3.x) and above as well?

Revision history for this message
Yehouda (yeh-lispworks) wrote :

We didn't try on GTK 3.
We don't run our software on GTK 3 at all at the moment.

Revision history for this message
Olli Ries (ories) wrote :

Ryan, can you please see if this is still an issue and set the status accordingly

Changed in appmenu-gtk:
status: New → Incomplete
importance: Undecided → Medium
assignee: nobody → Ryan Lortie (desrt)
Revision history for this message
Allison Karlitskaya (desrt) wrote :

This is definitely not a Gtk bug.

affects: gtk+3.0 (Ubuntu) → ubuntu
Changed in ubuntu:
status: New → Invalid
Revision history for this message
Allison Karlitskaya (desrt) wrote :

It is definitely an appmenu-gtk bug, however. The original description is accurate. This should be a one-liner to fix.

Changed in appmenu-gtk:
status: Incomplete → New
Charles Kerr (charlesk)
Changed in appmenu-gtk:
status: New → Fix Committed
Charles Kerr (charlesk)
description: updated
Changed in appmenu-gtk:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.