UI doesn't show if a series initialization request failed, it just vanishes
Bug #795387 reported by
Ursula Junque
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Gavin Panella |
Bug Description
I requested an initialization of a series, in https:/
After that, the "Series initialisation in progress" text disappeared, and there was no other message or text informing the initialization failed, it just disappeared and the series page returned to the same it was before my request. There's no info about the failure or the request, while it's pending.
Related branches
lp:~allenap/launchpad/show-init-series-failure-bug-795387
- Aaron Bentley (community): Approve
-
Diff: 365 lines (+163/-20)12 files modifiedlib/lp/registry/browser/tests/test_distroseries.py (+87/-2)
lib/lp/registry/interfaces/distroseries.py (+6/-0)
lib/lp/registry/model/distroseries.py (+6/-3)
lib/lp/registry/templates/distroseries-index.pt (+1/-1)
lib/lp/registry/templates/distroseries-portlet-derivation.pt (+19/-0)
lib/lp/registry/tests/test_distroseries.py (+12/-1)
lib/lp/services/job/interfaces/job.py (+5/-0)
lib/lp/services/job/model/job.py (+5/-0)
lib/lp/services/job/tests/test_job.py (+7/-0)
lib/lp/soyuz/interfaces/distributionjob.py (+4/-2)
lib/lp/soyuz/model/initializedistroseriesjob.py (+5/-6)
lib/lp/soyuz/tests/test_initializedistroseriesjob.py (+6/-5)
Changed in launchpad: | |
assignee: | nobody → Gavin Panella (allenap) |
status: | Triaged → In Progress |
tags: | added: ui |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I have discussed this with jtv:
- On DistroSeries:+index we should only display a message that the
initialization has failed. We should not show a free-form error
message (which might contain tracebacks or sensitive information).
- For those users who can use DistroSeries: +initseries we can show
some additional instructions along with the failure message.
Most likely this will initially be a link to +initseries, to try
again, but as we become aware of the common failure modes we could
show something more appropriate.
- Because free-form error messages from jobs are not being displayed
anywhere, we need to ensure that OOPS reports are being recorded
when jobs fail.
- I need to talk to Huw about the appearance of the UI.