Investigate use of save_logging, reset_logging and remove them from tests
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
pyjuju |
Fix Released
|
Medium
|
Jim Baker |
Bug Description
A number of tests (mostly in ensemble.hook, but also in ensemble.control) use the pattern of save_logging/
At least one test is currently unreliable in trunk, due to a logging related issue, when looped repeatedly:
./test -u ensemble.
...
=======
[FAIL]
Traceback (most recent call last):
File "/usr/lib/
result = g.send(result)
File "/home/
self.
File "/home/
return self.assertIn(
twisted.
ensemble.
-------
Ran 23 tests in 11.353s
FAILED (failures=1, successes=22)
At standup, it was determined that this usage should be investigated, conclusions reported to the mailing list, and removed from code so as to be more consistent with other tests.
Related branches
- Kapil Thangavelu (community): Approve
- Gustavo Niemeyer: Approve
-
Diff: 557 lines (+62/-166)7 files modifiedensemble/control/tests/test_status.py (+5/-5)
ensemble/hooks/invoker.py (+1/-1)
ensemble/hooks/tests/test_arguments.py (+2/-5)
ensemble/hooks/tests/test_cli.py (+7/-12)
ensemble/hooks/tests/test_communications.py (+12/-13)
ensemble/hooks/tests/test_invoker.py (+35/-49)
ensemble/lib/testing.py (+0/-81)
Changed in ensemble: | |
importance: | Undecided → Medium |
assignee: | nobody → Jim Baker (jimbaker) |
milestone: | none → dublin |
Changed in ensemble: | |
status: | New → In Progress |
Changed in ensemble: | |
status: | In Progress → Fix Released |
tags: | added: expose |