Holdings maintenance bug when using library dropdown to select a library's holdings

[Shae]

Reported first by a customer, I went to an in house system on 2.0.6 to test this. Steps to replicate the problem:

1. Search the catalog and pull up a record that has holdings for several libraries (or at least two).

2. Go to Holdings Maintenance.

3. Select the drop down menu that shows you which libraries have holdings.

NOTE: It's important in the example that the last library be one that has holdings in order to replicate this fully.

4. Try selecting the last library to show their holdings only.

What's happening is the cursor always has to be just below the library name in order to highlight it. In the case of the last library on the list, your cursor is actually showing up too far below in the holdings maintenance window, where the copies are. Therefore, you can't ever select the last library. You click and it just clicks you out of the drop down.

Don't remember seeing this on any other version. If you need to know the in house system I used, let me know.

[Michael Peters (mrpeters)]

Applies to 2.0.4 as well.

[Michael Peters (mrpeters)]

This is caused by the "Green and bold in the list below means the library has volumes for this record." that appears when the dropdown is rendered.

Removing that bit of code allows you to click directly on each dropdown row properly.

Plotting a solution..

[Michael Peters (mrpeters)]

Fix attached

Thanks to tsbere for the alternate (and better!) way of fixing this!

[Michael Peters (mrpeters)]

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=669d00589802acfb18ff33abe5fd2ca46522ac63

[Ben Shum (bshum)]

Tested with our 2.0 system and works nicely. Good job mrpeters and tsbere!

[Mike Rylander (mrylander)]

cherry-picked into master, 2.1 and 2.0, thanks folks.