indicator-session: ftbfs with gcc-4.6 -Werror

[Evgeni Golov]

Quoting the original bug report (http://bugs.debian.org/625356):

This package builds with -Werror, and GCC 4.6 triggers new warnings
which will make the package fail to build. Currently a Debian patch
just passes
    -Wno-error=unused-but-set-variable and
    -Wno-error=unused-but-set-parameter
to avoid build failures, but this patch will be reverted with the
GCC 4.6.1 release, and the severity of the report will be raised.

The full build log can be found at:
http://people.debian.org/~doko/tmp/werror/indicator-session_0.2.15-1_lsid64.buildlog

The relevant lines in the log are:
users-service-dbus.c: In function 'seat_proxy_session_added':
users-service-dbus.c:589:18: warning: variable 'res' set but not used [-Wunused-but-set-variable]

The variable is really unused there. Either return res, or just ignore the return value of do_add_session completely.

Regards
Evgeni

[Conor Curran (cjcurran)]

I just checked trunk and it seemed this has been fixed but the bug has not been updated.
Marking upstream fix released, will consult with the previous maintainer before marking debian's bug resolved.