Doesn't show window if launched not from terminal

[Sergey "Shnatsel" Davidoff]

Marlin doesn't show the main window if it wasn't launched from terminal. Before bzr revision 370 it worked if launched from slingshot but didn't work if launched from plank. After rev 370 it doesn't work at all if launched not from terminal.

For some mysterious reason, switching from "terminal=false" to "terminal=true" fixes this bug for slingshot. can't test for plank because it shows no icon in this case.

Output from xsession-errors when launching from Slingshot:

** (slingshot:16988): CRITICAL **: slingshot_frontend_indicators_set_active: assertion `self != NULL' failed
** (process:15836): DEBUG: zeitgeist-datahub.vala:174: Inserting 1 events

(slingshot:16988): Gtk-CRITICAL **: IA__gtk_style_detach: assertion `style->attach_count > 0' failed
Gtk-Message: Failed to load module "canberra-gtk-module"
[INFO 10:24:36.975751] Welcome to Marlin
[INFO 10:24:36.975939] Version: 0.1
[INFO 10:24:36.975992] Report any issues/bugs you might find to lp:marlin
application/x-shared-library-la
application/x-shared-library-la
text/plain
Contractor doesn't know this hook: 6
text/plain
Init the plugin
application/x-sharedlib
application/x-sharedlib
application/x-sharedlib
application/x-sharedlib
application/x-sharedlib
application/x-sharedlib
** (process:15836): DEBUG: zeitgeist-datahub.vala:174: Inserting 1 events
** (process:15836): DEBUG: zeitgeist-datahub.vala:174: Inserting 1 events

[Sergey "Shnatsel" Davidoff (shnatsel)]

see also bug #792733 for more test cases

[xapantu (xapantu)]

Here it works fine (from unity launcher). Your debug print is useless, it only shows slingshot things and a few marlin debug output for the plugin, but that's all.

Rev 370: I made only internal marlin changes for the pathbar
Rev 371 and 372: you changed some things in the .desktop file, so, this bug is related to these commits.

I can't reproduce your bug, but if you think it really exists, please fix it or revert your patch :)

Next time, if you are not sure about your commit, maybe you could work on a separate branch and ask for merge.

[Sergey "Shnatsel" Davidoff (shnatsel)]

xapantu: could you try it with Plank from https://launchpad.net/~ricotz/+archive/docky with your latest revision (370)? It should confirm the bug.

Also, those modifications I did are fd.o compliant and are copied from Nautilus entries, so I assume they are working fine. update-desktop-database command doesn't print any warnings or errors on them (it does e.g. for gloobus-preview).

[Sergey "Shnatsel" Davidoff (shnatsel)]

Plank also works with "terminal=true" in .desktop (it recognized it after a reboot), so the bug was not introduced by me.

[Sergey "Shnatsel" Davidoff (shnatsel)]

Wow. If I launch it from Plank, it doesn't work, but if I kill Plank and launch it from terminal,Marlin writes its output to the same terminal and works fine.

[Sergey "Shnatsel" Davidoff (shnatsel)]

Then it's a bug in Slingshot, too.

[Sergey "Shnatsel" Davidoff (shnatsel)]

See also bug #511511