Clear BPM displays on eject

[jus]

1. Load and play a track in player 2
2. Stop playback at a point with high volume
3. Instantly eject track using the EJECT button
4. Notice how the VUmeter is not reset

I first noticed this when using the AutoDJ branch lp:~daschuer/mixxx/autodj (the track load behavior is different there, so the issue is always visible), but this bug is also with current trunk

[jus (jus)]

This is not only with Player 2 as originally thought, but with all players (even samplers).
Tested with latest trunk.

[RJ Skerry-Ryan (rryan)]

EngineObjects need to get an onTrackLoaded/Unloaded callback so that we can clear these indicators.

[jus (jus)]

The decks BPM display will not reset on eject as well.

[Roman Botnari (rroman-botnari)]

I managed to reset the bpm by updating(reseting) the visualBpm in enginebuffer.cpp in the ejectTrack() method. It works on both decks. Is it the right method of doing this or do you think i should try to solve this differently?

[RJ Skerry-Ryan (rryan)]

Hey Roman,

Thanks for working on this. Your suggestion worked fine and I've committed it to lp:mixxx/1.10.

The VU-meter side of this is tricky since they are separate from EngineBuffer. I think that I won't fix that now and in the enginecontrol-refactor branch I will refactor things so that eject is handled by BaseTrackPlayer/EngineDeck instead of EngineBuffer. That way all EngineObjects in a given channel can receive load/unload callbacks.

[Roman Botnari (rroman-botnari)]

Hi,
if you can explain to me how that part functions a litte bit more, maybe i
can do it.

Thank you

On 4 May 2012 05:34, RJ Ryan <email address hidden> wrote:

> Hey Roman,
>
> Thanks for working on this. Your suggestion worked fine and I've
> committed it to lp:mixxx/1.10.
>
> The VU-meter side of this is tricky since they are separate from
> EngineBuffer. I think that I won't fix that now and in the
> enginecontrol-refactor branch I will refactor things so that eject is
> handled by BaseTrackPlayer/EngineDeck instead of EngineBuffer. That way
> all EngineObjects in a given channel can receive load/unload callbacks.
>
> ** Summary changed:
>
> - Channel volume meter and BPM displays are on eject
> + Clear BPM displays on eject
>
> ** Changed in: mixxx
> Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/791131
>
> Title:
> Clear BPM displays on eject
>
> Status in Mixxx:
> Fix Committed
>
> Bug description:
> 1. Load and play a track in player 2
> 2. Stop playback at a point with high volume
> 3. Instantly eject track using the EJECT button
> 4. Notice how the VUmeter is not reset
>
> I first noticed this when using the AutoDJ branch
> lp:~daschuer/mixxx/autodj (the track load behavior is different there,
> so the issue is always visible), but this bug is also with current
> trunk
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/791131/+subscriptions
>

--
Roman Botnari

blog: http://fwddub.net/ <http://fwddub.blogspot.com/>
T: [phone]

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5916