Search summary shows MISSING, LOST, and other usually hidden copies

Bug #790916 reported by Dan Scott
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Dan Scott

Bug Description

* Evergreen 2.0.6
* OpenSRF 2.0.0
* PostgreSQL 9.0.4

Evergreen 2.0 introduced a standard copy summary on the search results page. This draws from the holdings summary XML served up from unAPI, which includes copies which have been deleted, or which have a status of MISSING, LOST, etc.

I have pushed a branch to the working repo containing a significant refinement of the copy summary code at user/dbs/fix-search-summary

Tags: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

I tested this patch in the wild with our production environment and library staff liked most of it, but found the copy status limitations very confusing. Searching in the staff client / OPAC went without "Checked Out" items showing up since it wasn't one of the hardcoded values being checked for.

Dan Scott suggested in IRC that the copy status filter should filter on config.copy_status.opac_visible (and that while hardcoding values that correspond to the default settings in that table may be a good start, the holdings_xml should be taught to show that status directly).

Revision history for this message
Dan Scott (denials) wrote :

Thanks for the testing, Ben!

I have committed one more change to that branch that filters on copy status matching the defaults for opac visibility in config.copy_status, which should do a much better job of meeting expectations (at least until holdings XML adds an opac_visible attribute to the status element).

Revision history for this message
Dan Scott (denials) wrote :

Oh, and I pushed another commit to the same branch to add the opac_visible attribute to the status element in holdings XML, and I've revised the search summary code to take advantage of that.

Revision history for this message
Dan Scott (denials) wrote :

Pushed the fixes into master through rel_2_0.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: nobody → Dan Scott (denials)
milestone: none → 2.0.7
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.