pping can crash if clock is adjusted backwards

Bug #790178 reported by Gunnar Rangøy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Network Administration Visualized
Fix Released
Undecided
Christian Strand Young

Bug Description

db.py:query:120 [Debug] Executing: SELECT rrd_fileid, netboxid FROM rrd_file
               WHERE path='/var/lib/nav/rrd' AND
                     filename='x.y.z.100.rrd'
Traceback (most recent call last):
  File "/usr/lib/nav/pping.py", line 271, in <module>
    start(nofork)
  File "/usr/lib/nav/pping.py", line 239, in start
    myPinger.main()
  File "/usr/lib/nav/pping.py", line 172, in main
    self.generateEvents()
  File "/usr/lib/nav/pping.py", line 117, in generateEvents
    rrd.update(netbox.netboxid, netbox.sysname, 'N', 'DOWN', 5)
  File "/usr/lib/pymodules/python2.5/nav/statemon/rrd.py", line 131, in update
    rrd.update(*rrdParam)
rrdtool.error: /var/lib/nav/rrd/x.y.z.100.rrd: illegal attempt to update using time 1306756336 when last update time is 1306757036 (minimum one second step)

Revision history for this message
Morten Brekkevold (mbrekkevold) wrote :

Christian, could you please look at this? I understand the exception thrown by rrdtool, this is normal behavior.

It is not acceptable for the pping daemon to crash because of this error. IMHO, it should log the incident and ignore it (meaning that no further updated will go into the RRD file until the clock passes the last update time again).

Changed in nav:
status: New → Triaged
assignee: nobody → Christian Strand Young (lizter)
Changed in nav:
milestone: none → 3.9.1
status: Triaged → Fix Committed
Changed in nav:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.