bad values from xwax timecoder

[Owen Williams]

What I thought would be a simple one-liner is causing problems. In xwax's timecoder.c, I want to normalize the timecode to represent milliseconds instead of "timecoder steps." Technically we lose precision with vinyl like traktor (since it's supposedly accurate to 1/2 millisecond) but it's much cleaner to problem for.

So I wrote this line (at the end of the file):

if (r >= 0) {
//normalize position to milliseconds, not timecode steps -- Owen
r = r * 1000 / (tc->def->resolution * tc->speed);
...

However I seem to suck at math, because every so often this will spit out a gigantic value -- originally because I did the math before I tested for r>=0, which (maybe?) caused unsigned integer math barf. But it's still capable of spitting out gigantic values, so there's still something wrong.

What's the right way to write this line so all the numbers behave? I'm thinking:

r = (float)r * (1000.0 / (tc->def->resolution * tc->speed));

(r is a signed int, resolution is an int, and speed is a double)

[RJ Skerry-Ryan (rryan)]

When the value goes gigantic -- what are the values of all the other variables? Can you log it or something?

[Owen Williams (ywwg)]

I did my fix as indicated, and this hasn't been a problem in a while. closing.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5908