Once an application moderator has approved an application it's currently moved into the ReviewApproved state. This name seemed natural when it was created, as it's the state applications go into once they've approved the review. Still, it's confusing for a couple of reasons:
- We're inverting the naming convention from "what's expected to happen next" (as in PendingReview or ReadyToPublish) to "what's just happened". In this sense, PendingFinalApproval or PendingTests would be a better name.
- Once the app is in a state called ReviewApproved, I'd imagine it's ready to go public, and yet it isn't. This is just a matter of communication, but still a name that conveys that there's still something missing would be clearer.
QA notes: This would be qa-untestable except for the fact that we updated the text in the emails to better match what's actually going on (while trying to remain consistent to the choice of words). See the diff below for the expected wording for reject, moderator approve, qa approve, needs info etc.
+1 for PendingTests or PendingQA even.