rate limits builder uses incorrect key
Bug #787023 reported by
Alex Meade
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Medium
|
Alex Meade |
Bug Description
The view buider in limits.py has a mistype:
for limit in limits:
if limit["uri"] == rate_limit["URI"] and \
the line should read:
limit["regex"] == rate_limit[
Currently, if there were multiple limits on actions with the same uri but different regexes it would wrongfully be considered the same action (I'm not sure that is even possible); potentially causing the limits to display incorrectly.
Related branches
lp:~rackspace-titan/nova/lp787023
- Brian Waldon (community): Approve
- Mark Washenberger (community): Approve
- Jay Pipes (community): Approve
-
Diff: 74 lines (+52/-1)2 files modifiednova/api/openstack/views/limits.py (+1/-1)
nova/tests/api/openstack/test_limits.py (+51/-0)
Changed in nova: | |
assignee: | nobody → Alex Meade (alex-meade) |
Changed in nova: | |
status: | New → In Progress |
Changed in nova: | |
status: | In Progress → Fix Committed |
status: | Fix Committed → In Progress |
Changed in nova: | |
importance: | Undecided → Medium |
Changed in nova: | |
status: | In Progress → Fix Committed |
Changed in nova: | |
milestone: | none → diablo-1 |
Changed in nova: | |
milestone: | diablo-1 → 2011.3 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.